[hotfix] Fix the issue related to mounting the Logback configuration … #25995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidradl
reviewed
Jan 16, 2025
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/utils/Constants.java
Show resolved
Hide resolved
davidradl
reviewed
Jan 16, 2025
| if (log4jFile.exists()) { | ||
| localLogConfFiles.add(log4jFile); | ||
|
|
||
| for (String fileName : CONFIG_FILE_NAME_LIST) { |
There was a problem hiding this comment.
can we have a junit for this this please.
There was a problem hiding this comment.
Thank you for your suggestions. I have made improvements. Please review.
Jam804
force-pushed
the
k8s_conf_mount
branch
2 times, most recently
from
b7f72db to
6715ba6
Compare
|
@Jam804 looks like spotless is showing format issues that need to be fixed before the CI with work. |
Jam804
force-pushed
the
k8s_conf_mount
branch
from
6715ba6 to
b16686b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flink on Kubernetes has these configuration files mounted by default, but some are incomplete, leading to certain features being unavailable.