[FLINK-37093][table] Fix catalog that failed validation due to no type still exists in catalogStoreHolder #25946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidradl
approved these changes
Jan 15, 2025
|
Reviewed by Chi on 16/01/2025 Approve - looking for committer to merge |
jiefei30
changed the title
hackergin
reviewed
Jan 17, 2025
| @@ -589,6 +600,7 @@ void testCatalogStore() throws Exception { | |||
| assertTrue(catalogManager.listCatalogs().contains("cat2")); | |||
| assertTrue(catalogManager.listCatalogs().contains("cat3")); | |||
| assertTrue(catalogManager.listCatalogs().contains("cat_comment")); | |||
| assertFalse(catalogManager.listCatalogs().contains("cat_no_type")); | |||
There was a problem hiding this comment.
Would it be better to put this assertion together with the above assertThatThrownBy?
…e still exists in catalogStoreHolder
|
@hackergin done. |
|
cc @fsk119 please help review this PR when you are free. Thank you very much. |
|
need I backport this fix to release-2.0 ? @hackergin @fsk119 |
Please help backport to 2.0 and 1.20. I think 1.19 can also be fixed. |
done. #26138 #26141 @hackergin |
Au-Miner
pushed a commit
to Au-Miner/flink
that referenced
this pull request
Feb 23, 2025
…nition in catalog store(apache#25946)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request fix a bug which a catalog that failed validation due to no type still exists in catalogStoreHolder.
And this catalog you cannot USE, ALTER.
Brief change log
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation