fix(pictorial): fix zero value flipping for different axes #20557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echarts-bot
bot
added
PR: author is committer
PR: awaiting review
PR: doc unchanged
labels
|
Thanks for your contribution! The pull request is marked to be |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20557@6e9ef3b |
plainheart
approved these changes
Dec 4, 2024
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
When checking if the symbol should be flipped with zero value, it's different situations to consder when axis is horizontal/vertical and whether is inversed. #20300 tried to fix one situation but didn't consider others so it brought bug with
test/pictorial-zero-value-offset.html.This PR fix this problem and provided test cases with the combination of horizontal/vertical axis and whether or not inversed.
Fixed issues
Details
Before: What was the problem?
test/pictorial-zero-value-offset.htmlhas a wrong flipped symbol.After: How does it behave after the fixing?
test/pictorial-zero-value-offset.htmlhas no diff with 5.5.1 and fix all possible situations with the axis.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information