Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): enhance grid.containLabel #20542

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chengzhanli
Copy link

@chengzhanli chengzhanli commented Nov 27, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Enhances the grid.containLabel property in ECharts to allow specifying the direction (horizontal or vertical) for label containment.

Fixed issues

#20540

Details

Before: What was the problem?

The grid.containLabel property was a simple boolean flag, which only enabled or disabled label containment. It lacked granularity, making it difficult to handle specific directions (e.g., only horizontal or vertical).

After: How does it behave after the fixing?

The grid.containLabel property now supports specifying the direction (horizontal or vertical) for label containment. This allows more precise control over grid size adjustments based on axis labels.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot echarts-bot bot added PR: awaiting doc Document changes is required for this PR. PR: first-time contributor labels Nov 27, 2024
Copy link

echarts-bot bot commented Nov 27, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@chengzhanli chengzhanli marked this pull request as ready for review November 27, 2024 06:12
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test cases according to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants