Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sankey): avoid throwing errors when the links / nodes / levels option is undefined #20380

Merged
merged 5 commits into from
Sep 29, 2024

Conversation

sz-p
Copy link
Contributor

@sz-p sz-p commented Sep 28, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

#20336

Details

Before: What was the problem?

getInitialData function may return uncatched undefined

After: How does it behave after the fixing?

Catch undefined data like the other graph chart

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Sep 28, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@plainheart plainheart linked an issue Sep 29, 2024 that may be closed by this pull request
@plainheart plainheart added this to the 5.5.2 milestone Sep 29, 2024
@plainheart plainheart changed the title fixed(sankey): getInitialData function may return uncatched undefined fix(sankey): avoid throwing errors when the links / nodes / levels option is undefined Sep 29, 2024
Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20380@d60b241

@plainheart plainheart merged commit bb12cee into apache:master Sep 29, 2024
2 checks passed
Copy link

echarts-bot bot commented Sep 29, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] getInitialData function may return uncatched undefined
2 participants