Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typos #19473

Merged
merged 1 commit into from
Jan 7, 2024
Merged

chore: fix some typos #19473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ exports.createECharts = function (opt = {}) {
opt,
{
name: 'echarts',
// Ignore default exports, which is only for compitable code like:
// Ignore default exports, which is only for compatible code like:
// import echarts from 'echarts/lib/echarts';
exports: 'named',
format: format
Expand Down
4 changes: 2 additions & 2 deletions build/pre-publish.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

/**
* [Create CommonJS files]:
* Compatible with prevoius folder structure: `echarts/lib` exists in `node_modules`
* Compatible with previous folder structure: `echarts/lib` exists in `node_modules`
* (1) Build all files to CommonJS to `echarts/lib`.
* (2) Remove __DEV__.
* (3) Mount `echarts/src/export.js` to `echarts/lib/echarts.js`.
Expand Down Expand Up @@ -206,7 +206,7 @@ module.exports = async function () {
};

async function runTsCompile(localTs, compilerOptions, srcPathList) {
// Must do it. becuase the value in tsconfig.json might be different from the inner representation.
// Must do it, because the value in tsconfig.json might be different from the inner representation.
// For example: moduleResolution: "NODE" => moduleResolution: 2
const {options, errors} = localTs.convertCompilerOptionsFromJson(compilerOptions, ecDir);

Expand Down
2 changes: 1 addition & 1 deletion src/data/helper/sourceHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ export function querySeriesUpstreamDatasetModel(
export function queryDatasetUpstreamDatasetModels(
datasetModel: DatasetModel
): DatasetModel[] {
// Only these attributes declared, we by defualt reference to `datasetIndex: 0`.
// Only these attributes declared, we by default reference to `datasetIndex: 0`.
// Otherwise, no reference.
if (!datasetModel.get('transform', true)
&& !datasetModel.get('fromTransformResult', true)
Expand Down