Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add edgeName to sankey #18101

Closed
wants to merge 1 commit into from
Closed

add edgeName to sankey #18101

wants to merge 1 commit into from

Conversation

ZNackasha
Copy link

@ZNackasha ZNackasha commented Dec 24, 2022

Brief Information

this will allow the user to give a custom edge name on the edge of a Sankey

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

simply adds a variable to override the default edge name

Fixed issues

Details

Before: What was the problem?

After: How does it behave after the fixing?

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Dec 24, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

@echarts-bot echarts-bot bot added the PR: awaiting doc Document changes is required for this PR. label Dec 24, 2022
@echarts-bot
Copy link

echarts-bot bot commented Dec 24, 2022

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@Ovilia
Copy link
Contributor

Ovilia commented Dec 26, 2022

If you want to custom the tooltip, you can use series.tooltip.formatter like this demo. Otherwise, please explain in which cases this is necessary. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants