fix: use precision defaults only when markline type is average #15324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Map1en
changed the title
|
Any news on this one, or any reason this was never merged? We just ran into this issue and it feels strange that the default precision of 2 is applied here. Happy to pick up the PR and rebase it if we agree that this will be changed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
fix: rm default val of precision and calc val automatically
Fixed issues
close #15247
Details
Before: What was the problem?
The max and min markline should not follow the precision option
After: How is it fixed in this PR?
Use precision defaults only when markline type is average
Misc
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information