Skip to content

Commit

Permalink
Merge pull request #19473 from striezel-stash/fix-typos
Browse files Browse the repository at this point in the history
chore: fix some typos
  • Loading branch information
plainheart authored Jan 7, 2024
2 parents 9d61cbc + 0df7c0d commit 9711002
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion build/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ exports.createECharts = function (opt = {}) {
opt,
{
name: 'echarts',
// Ignore default exports, which is only for compitable code like:
// Ignore default exports, which is only for compatible code like:
// import echarts from 'echarts/lib/echarts';
exports: 'named',
format: format
Expand Down
4 changes: 2 additions & 2 deletions build/pre-publish.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

/**
* [Create CommonJS files]:
* Compatible with prevoius folder structure: `echarts/lib` exists in `node_modules`
* Compatible with previous folder structure: `echarts/lib` exists in `node_modules`
* (1) Build all files to CommonJS to `echarts/lib`.
* (2) Remove __DEV__.
* (3) Mount `echarts/src/export.js` to `echarts/lib/echarts.js`.
Expand Down Expand Up @@ -206,7 +206,7 @@ module.exports = async function () {
};

async function runTsCompile(localTs, compilerOptions, srcPathList) {
// Must do it. becuase the value in tsconfig.json might be different from the inner representation.
// Must do it, because the value in tsconfig.json might be different from the inner representation.
// For example: moduleResolution: "NODE" => moduleResolution: 2
const {options, errors} = localTs.convertCompilerOptionsFromJson(compilerOptions, ecDir);

Expand Down
2 changes: 1 addition & 1 deletion src/data/helper/sourceHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ export function querySeriesUpstreamDatasetModel(
export function queryDatasetUpstreamDatasetModels(
datasetModel: DatasetModel
): DatasetModel[] {
// Only these attributes declared, we by defualt reference to `datasetIndex: 0`.
// Only these attributes declared, we by default reference to `datasetIndex: 0`.
// Otherwise, no reference.
if (!datasetModel.get('transform', true)
&& !datasetModel.get('fromTransformResult', true)
Expand Down

0 comments on commit 9711002

Please sign in to comment.