Merge pull request #19516 from apache/fix/mark-area

fix(marker): fix markArea position when axis is with `alignWithLabel`
apache · Jan 16, 2024 · 53bb9ff · 53bb9ff
2 parents 6cae00c + 3a056bd
commit 53bb9ff
Show file tree

Hide file tree

Showing 2 changed files with 309 additions and 2 deletions.
diff --git a/src/chart/bar/BaseBarSeries.ts b/src/chart/bar/BaseBarSeries.ts
@@ -101,11 +101,12 @@ class BaseBarSeriesModel<Opts extends BaseBarSeriesOption<unknown> = BaseBarSeri
                     // If axis type is category, use tick coords instead
                     if (axis.type === 'category' && dims != null) {
                         const tickCoords = axis.getTicksCoords();
+                        const alignTicksWithLabel = axis.getTickModel().get('alignWithLabel');
 
                         let targetTickId = clampData[idx];
                         // The index of rightmost tick of markArea is 1 larger than x1/y1 index
                         const isEnd = dims[idx] === 'x1' || dims[idx] === 'y1';
-                        if (isEnd) {
+                        if (isEnd && !alignTicksWithLabel) {
                             targetTickId += 1;
                         }
 

diff --git a/test/markArea.html b/test/markArea.html