-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete hightlight and downplay doc #279
Conversation
en/api/action.md
Outdated
@@ -36,54 +36,6 @@ Chart actions supported by ECharts are triggered through [dispatchAction](~echar | |||
|
|||
**Attention: ** The `?:` note in the code shows that this attribute is optional. *EVENT:* stands for the event that triggers action. | |||
|
|||
## highlight(Action) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't remove them as they are still working for other series or components.
The v5 upgrade guide indicates that the highlight
action & downplay
action in the sunburst
series are deprecated but not in all series.
Perhaps we should add new actions for sunburstHighlight
& sunburstUnhighlight
.
@pissang Please help review this PR. |
As @plainheart said, this change is only scoped to the sunburst series, it should be mentioned in the note |
I was confused because It should be. deprecateReplaceLog('sunburstHighlight', 'highlight'); So we should change this warning log instead of changing the doc |
It is stated in the V5 upgrade document that this is discarded in the sunrise chart,please check again 旭日图(sunburst): |
apache/echarts#17587 is following the right track. I think there should be no document changing required so I'm going to close this PR. Thanks for the help! |
fix issues#185