Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "reject publishing actions with a retriable error code if (#17509)" #17802

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Mar 14, 2025

The retries can cause TaskLockbox.giant lock to be held for a very long time causing ingestion to fail.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

…rlier task is still publishing (apache#17509)"

This reverts commit aca56d6.
@kfaraz
Copy link
Contributor Author

kfaraz commented Mar 17, 2025

Upon reverting this change, the failures will start to recur.
I think we should do the retry either at the task level or at the task action level instead of retrying the transaction in IndexerSQLMetadataStorageCoordinator.

I will update this PR accordingly.

@kfaraz
Copy link
Contributor Author

kfaraz commented Mar 19, 2025

@cryptoe , I am thinking we should just merge this revert as is.
I am creating a separate patch for the final fix.
Having two separate PRs will make backports cleaner.

Please let me know what you think.

@cryptoe
Copy link
Contributor

cryptoe commented Mar 19, 2025

Yeah I think having separate fixes makes things easier. With the upcoming April 1st druid code freeze, we can choose to fix the root issue after the code freeze as well.

@kfaraz
Copy link
Contributor Author

kfaraz commented Mar 19, 2025

Merging this PR.

@kfaraz kfaraz merged commit 27850a7 into apache:master Mar 19, 2025
75 checks passed
@kfaraz kfaraz deleted the revert_retry_segment_publish branch March 19, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants