Skip to content

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Dec 4, 2025

What problem does this PR solve?

A const column is not allowed to be nested; it may only appear as the outermost (top-level) column.
Only 0 and 1 are allowed in the nullmap.

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Dec 4, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34291 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d747e3efbf443849719b6cb1c8d427d500b4e70f, data reload: false

------ Round 1 ----------------------------------
q1	17645	5087	4906	4906
q2	2055	313	201	201
q3	10264	1322	742	742
q4	10216	830	324	324
q5	7544	2506	2140	2140
q6	191	168	135	135
q7	964	806	629	629
q8	9371	1380	1150	1150
q9	7122	5318	5344	5318
q10	6779	2205	1786	1786
q11	541	299	294	294
q12	341	362	216	216
q13	17761	3694	3004	3004
q14	238	242	219	219
q15	587	513	511	511
q16	865	880	827	827
q17	672	803	537	537
q18	7533	7074	7178	7074
q19	1236	975	608	608
q20	364	357	229	229
q21	3996	3088	2510	2510
q22	1032	1041	931	931
Total cold run time: 107317 ms
Total hot run time: 34291 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4896	4888	4895	4888
q2	320	390	334	334
q3	2180	2664	2298	2298
q4	1330	1783	1310	1310
q5	4243	4472	4643	4472
q6	233	182	138	138
q7	2089	1992	1793	1793
q8	2758	2604	2597	2597
q9	7497	7588	7432	7432
q10	3056	3259	2820	2820
q11	585	582	560	560
q12	692	754	614	614
q13	3540	3966	3416	3416
q14	286	300	281	281
q15	554	507	514	507
q16	909	926	864	864
q17	1169	1604	1450	1450
q18	8199	7631	7636	7631
q19	872	898	906	898
q20	2022	2046	1885	1885
q21	4955	4525	4139	4139
q22	1106	1037	968	968
Total cold run time: 53491 ms
Total hot run time: 51295 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 181779 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d747e3efbf443849719b6cb1c8d427d500b4e70f, data reload: false

query5	5452	639	503	503
query6	337	238	224	224
query7	4646	528	305	305
query8	310	263	249	249
query9	8741	2627	2644	2627
query10	568	355	309	309
query11	15387	15162	14889	14889
query12	204	117	120	117
query13	1686	582	454	454
query14	6831	3280	3009	3009
query14_1	2965	2971	2918	2918
query15	217	197	190	190
query16	7674	701	551	551
query17	1317	789	636	636
query18	2040	442	356	356
query19	222	211	178	178
query20	129	125	124	124
query21	218	137	117	117
query22	3790	4084	3852	3852
query23	16612	16132	15950	15950
query23_1	16181	16009	16093	16009
query24	6814	1637	1200	1200
query24_1	1221	1205	1235	1205
query25	654	546	496	496
query26	1253	295	182	182
query27	2695	514	344	344
query28	4356	2192	2175	2175
query29	844	656	530	530
query30	323	252	216	216
query31	820	701	608	608
query32	85	75	77	75
query33	620	392	388	388
query34	826	868	532	532
query35	792	828	732	732
query36	891	952	849	849
query37	128	116	86	86
query38	3848	3818	3788	3788
query39	766	760	723	723
query39_1	694	689	696	689
query40	230	144	118	118
query41	67	61	62	61
query42	126	114	109	109
query43	441	449	419	419
query44	1318	752	751	751
query45	200	190	185	185
query46	902	1008	662	662
query47	1702	1730	1632	1632
query48	401	442	333	333
query49	750	495	420	420
query50	698	704	407	407
query51	4002	3888	3908	3888
query52	117	116	106	106
query53	242	258	195	195
query54	305	288	270	270
query55	100	93	91	91
query56	329	342	316	316
query57	1150	1139	1071	1071
query58	284	266	268	266
query59	2328	2427	2323	2323
query60	357	351	334	334
query61	162	163	156	156
query62	784	713	629	629
query63	227	196	195	195
query64	4483	1198	885	885
query65	3995	3964	3994	3964
query66	1062	424	330	330
query67	15328	14948	14832	14832
query68	8419	989	648	648
query69	535	341	309	309
query70	1075	1055	1018	1018
query71	497	338	326	326
query72	5799	4871	4803	4803
query73	703	571	342	342
query74	8655	8846	8610	8610
query75	3724	3046	2527	2527
query76	3704	1150	744	744
query77	821	405	310	310
query78	9529	9515	8826	8826
query79	2022	856	598	598
query80	648	580	476	476
query81	486	265	241	241
query82	451	144	110	110
query83	276	261	241	241
query84	255	122	92	92
query85	880	487	430	430
query86	362	330	270	270
query87	4034	4086	3965	3965
query88	4018	2254	2277	2254
query89	389	341	296	296
query90	2004	220	214	214
query91	176	170	142	142
query92	84	71	63	63
query93	1770	1032	673	673
query94	723	453	351	351
query95	512	418	386	386
query96	538	561	284	284
query97	2624	2681	2574	2574
query98	265	214	211	211
query99	1416	1374	1232	1232
Total cold run time: 272272 ms
Total hot run time: 181779 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.06 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d747e3efbf443849719b6cb1c8d427d500b4e70f, data reload: false

query1	0.05	0.04	0.05
query2	0.10	0.05	0.05
query3	0.26	0.09	0.08
query4	1.61	0.11	0.10
query5	0.25	0.25	0.24
query6	1.18	0.65	0.63
query7	0.03	0.03	0.02
query8	0.06	0.04	0.04
query9	0.57	0.50	0.50
query10	0.56	0.56	0.56
query11	0.17	0.10	0.11
query12	0.14	0.12	0.11
query13	0.62	0.59	0.60
query14	0.99	0.96	0.98
query15	0.82	0.78	0.80
query16	0.40	0.41	0.38
query17	0.98	1.00	1.05
query18	0.23	0.22	0.21
query19	1.83	1.86	1.84
query20	0.02	0.01	0.02
query21	15.45	0.29	0.14
query22	4.87	0.06	0.04
query23	16.19	0.28	0.10
query24	1.51	0.59	0.26
query25	0.10	0.06	0.04
query26	0.15	0.13	0.13
query27	0.07	0.05	0.06
query28	3.24	1.23	1.04
query29	12.55	3.96	3.18
query30	0.28	0.13	0.12
query31	2.82	0.63	0.40
query32	3.23	0.54	0.47
query33	3.02	3.10	3.04
query34	16.94	5.22	4.46
query35	4.57	4.56	4.52
query36	0.65	0.50	0.49
query37	0.11	0.07	0.06
query38	0.07	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.04	0.03
query42	0.04	0.04	0.03
query43	0.04	0.03	0.04
Total cold run time: 97.06 s
Total hot run time: 27.06 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (51/51) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.36% (18639/34929)
Line Coverage 39.02% (172141/441130)
Region Coverage 33.63% (133306/396359)
Branch Coverage 34.59% (57365/165844)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (51/51) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.20% (24728/34251)
Line Coverage 58.86% (259432/440751)
Region Coverage 53.78% (215752/401179)
Branch Coverage 55.29% (92199/166743)

@Mryange
Copy link
Contributor Author

Mryange commented Dec 4, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 35033 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 59c484bab9130401c5c1edf3137aa5a0dd8a8023, data reload: false

------ Round 1 ----------------------------------
q1	17646	5071	4936	4936
q2	2089	321	212	212
q3	10218	1367	782	782
q4	10206	792	324	324
q5	7569	2543	2216	2216
q6	198	177	139	139
q7	1000	831	656	656
q8	9372	1565	1271	1271
q9	7145	5602	5397	5397
q10	6870	2221	1791	1791
q11	540	327	303	303
q12	357	384	239	239
q13	17809	3680	3055	3055
q14	249	240	223	223
q15	599	520	519	519
q16	925	877	849	849
q17	706	835	552	552
q18	7498	7191	6965	6965
q19	934	988	648	648
q20	395	376	238	238
q21	4099	3902	2747	2747
q22	1084	1003	971	971
Total cold run time: 107508 ms
Total hot run time: 35033 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4986	4991	4942	4942
q2	329	400	326	326
q3	2173	2706	2319	2319
q4	1381	1818	1286	1286
q5	4422	4672	4489	4489
q6	220	179	132	132
q7	2088	2060	1829	1829
q8	2725	2665	2645	2645
q9	7635	7622	7480	7480
q10	3120	3295	2863	2863
q11	613	511	492	492
q12	703	724	606	606
q13	3600	3987	3391	3391
q14	301	290	291	290
q15	563	539	523	523
q16	955	961	903	903
q17	1288	1434	1470	1434
q18	8096	7760	7551	7551
q19	948	934	915	915
q20	2078	2067	1929	1929
q21	5102	4324	4116	4116
q22	1122	1081	971	971
Total cold run time: 54448 ms
Total hot run time: 51432 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 180835 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 59c484bab9130401c5c1edf3137aa5a0dd8a8023, data reload: false

query5	4608	683	506	506
query6	347	229	221	221
query7	4669	516	284	284
query8	302	248	242	242
query9	8723	2669	2657	2657
query10	537	312	275	275
query11	15296	14816	14850	14816
query12	173	123	120	120
query13	1695	498	392	392
query14	6351	3360	3114	3114
query14_1	3004	2976	2944	2944
query15	209	204	186	186
query16	7533	505	464	464
query17	1259	725	620	620
query18	2046	440	353	353
query19	237	195	169	169
query20	134	124	121	121
query21	223	142	129	129
query22	3890	4161	3917	3917
query23	16840	16167	15865	15865
query23_1	16189	16016	15917	15917
query24	7281	1674	1242	1242
query24_1	1245	1225	1249	1225
query25	658	504	461	461
query26	1269	289	193	193
query27	2861	482	313	313
query28	4369	2214	2207	2207
query29	847	604	537	537
query30	323	239	217	217
query31	863	718	650	650
query32	88	76	71	71
query33	661	356	307	307
query34	886	894	543	543
query35	811	832	738	738
query36	893	934	829	829
query37	121	95	77	77
query38	3955	3917	3744	3744
query39	846	743	732	732
query39_1	710	701	691	691
query40	230	137	123	123
query41	67	65	62	62
query42	140	101	96	96
query43	450	421	399	399
query44	1378	759	763	759
query45	204	201	188	188
query46	907	976	620	620
query47	1704	1732	1615	1615
query48	415	335	232	232
query49	789	434	358	358
query50	717	327	243	243
query51	3842	3859	3913	3859
query52	118	101	89	89
query53	247	236	183	183
query54	313	266	243	243
query55	97	82	79	79
query56	361	304	302	302
query57	1160	1143	1126	1126
query58	313	274	269	269
query59	2260	2377	2389	2377
query60	387	330	304	304
query61	158	201	166	166
query62	776	712	650	650
query63	243	181	190	181
query64	4526	1212	930	930
query65	4050	3979	4011	3979
query66	1219	456	358	358
query67	15861	15199	14869	14869
query68	8304	974	686	686
query69	531	309	285	285
query70	1116	961	989	961
query71	475	313	286	286
query72	6005	4907	4833	4833
query73	684	557	297	297
query74	8952	8807	8581	8581
query75	3320	3094	2490	2490
query76	3378	1174	761	761
query77	613	414	313	313
query78	9561	9698	8915	8915
query79	2076	886	597	597
query80	703	552	462	462
query81	518	277	248	248
query82	364	135	106	106
query83	281	277	269	269
query84	268	127	101	101
query85	967	515	447	447
query86	389	305	297	297
query87	4032	4050	3999	3999
query88	4288	2145	2141	2141
query89	399	324	286	286
query90	2064	167	164	164
query91	173	168	147	147
query92	84	71	65	65
query93	2099	1039	679	679
query94	775	311	306	306
query95	589	383	337	337
query96	559	506	214	214
query97	2650	2716	2552	2552
query98	254	203	198	198
query99	1380	1330	1229	1229
Total cold run time: 274153 ms
Total hot run time: 180835 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.56 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 59c484bab9130401c5c1edf3137aa5a0dd8a8023, data reload: false

query1	0.05	0.05	0.05
query2	0.12	0.06	0.06
query3	0.26	0.09	0.09
query4	1.61	0.12	0.11
query5	0.27	0.25	0.27
query6	1.16	0.64	0.66
query7	0.03	0.03	0.04
query8	0.06	0.05	0.04
query9	0.58	0.53	0.51
query10	0.56	0.55	0.56
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.61	0.62	0.60
query14	0.98	1.00	1.00
query15	0.82	0.81	0.80
query16	0.41	0.39	0.39
query17	1.02	1.05	1.06
query18	0.23	0.22	0.21
query19	1.98	1.82	1.76
query20	0.02	0.02	0.01
query21	15.44	0.32	0.14
query22	4.91	0.05	0.05
query23	16.14	0.30	0.10
query24	1.15	0.66	0.22
query25	0.09	0.06	0.06
query26	0.14	0.14	0.14
query27	0.09	0.06	0.07
query28	4.07	1.25	1.03
query29	12.58	4.05	3.32
query30	0.28	0.14	0.14
query31	2.81	0.63	0.40
query32	3.24	0.56	0.46
query33	3.04	3.05	3.08
query34	16.95	5.25	4.56
query35	4.55	4.58	4.59
query36	0.67	0.51	0.50
query37	0.11	0.08	0.06
query38	0.08	0.04	0.04
query39	0.05	0.04	0.03
query40	0.17	0.14	0.13
query41	0.09	0.04	0.04
query42	0.05	0.04	0.03
query43	0.04	0.04	0.03
Total cold run time: 97.82 s
Total hot run time: 27.56 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (59/59) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.35% (18639/34938)
Line Coverage 39.01% (172158/441278)
Region Coverage 33.65% (133402/396467)
Branch Coverage 34.58% (57369/165910)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (59/59) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.27% (24759/34260)
Line Coverage 58.96% (259934/440899)
Region Coverage 53.90% (216299/401287)
Branch Coverage 55.47% (92533/166809)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants