Skip to content

branch-4.0: [enhance](memory) back pressure writing when memory usage is high in sink operation #58530 #58704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: branch-4.0
Choose a base branch
from
Open

branch-4.0: [enhance](memory) back pressure writing when memory usage is high in sink operation #58530 #58704

wants to merge 1 commit into from

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Dec 4, 2025

Cherry-picked from #58530

@sollhui
[enhance](memory) back pressure writing when memory usage is high in …
47783b5 
…sink operation (#58530)

### What problem does this PR solve?

Now, each VNodeChannel limit `_pending_batches_bytes` by config
`nodechannel_pending_queue_max_bytes`, but it will still cause excessive
memory usage on too many BE nodes or high concurrency.

This pr introduce back pressure writing when memory usage is high in
`VTabletWriter` to solve the issue.
@github-actions github-actions bot requested a review from yiguolei as a code owner December 4, 2025 06:45
@Thearas
Copy link
Contributor

Thearas commented Dec 4, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Dec 4, 2025
@dataroaring dataroaring reopened this Dec 4, 2025
@Thearas
Copy link
Contributor

Thearas commented Dec 4, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Dec 4, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.28% (18416/34566)
Line Coverage 38.80% (169072/435703)
Region Coverage 33.58% (130860/389703)
Branch Coverage 34.47% (56430/163709)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei Awaiting requested review from yiguolei yiguolei is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thearas @doris-robot @dataroaring @sollhui