Skip to content

branch-3.1: [fix](nereids) fix pushdownLimit/topnThroughJoin dead loop #58305 #58697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 2 commits into from
Dec 5, 2025
Merged

branch-3.1: [fix](nereids) fix pushdownLimit/topnThroughJoin dead loop #58305 #58697

morrySnow merged 2 commits into from
Dec 5, 2025
+191 −10

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Dec 4, 2025 •
edited by morrySnow
Loading

picked from #58305

@englefly
[fix](nereids)fix pushdownLimit/topnThroughJoin dead loop (apache#58305)
8794327 
- PushDownTopNThroughJoin
- PushDownLimitDistinctThroughJoin
- PushDownTopNDistinctThroughJoin
in pr#46773, we made above rules both applicable to RBO and CBO. In
order to avoid dead loop, we have checked rewritten plan. But the check
condition is not suitable to CBO. This leads optimizor apply these rules
until group expression count reach memo_max_group_expression_size
@englefly
case
ea59ac5
@englefly englefly requested a review from morrySnow as a code owner December 4, 2025 03:37
@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 4, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly
Copy link
Contributor Author

englefly commented Dec 4, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 4, 2025

FE UT Coverage Report

Increment line coverage 43.48% (10/23) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow changed the title branch-3.1 [fix](nereids)fix pushdownLimit/topnThroughJoin dead loop #58305 branch-3.1: [fix](nereids) fix pushdownLimit/topnThroughJoin dead loop #58305 Dec 5, 2025
@morrySnow morrySnow merged commit c21f89d into apache:branch-3.1 Dec 5, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@englefly @hello-stephen @morrySnow