Skip to content

Conversation

@wumeibanfa
Copy link
Contributor

@wumeibanfa wumeibanfa commented Dec 3, 2025

What problem does this PR solve?

In the current version, be_exec_version >= USE_CONST_SERDE is always true, so the corresponding conditional branches in serialize, deserialize, and get_uncompressed_serialized_bytes of the datatype can be removed.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wumeibanfa
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34469 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 802495a3d1778f5f3b2aa33382c9ac749c67b747, data reload: false

------ Round 1 ----------------------------------
q1	17605	5050	4872	4872
q2	2073	328	221	221
q3	10207	1311	737	737
q4	10289	900	319	319
q5	8487	2457	2210	2210
q6	207	174	138	138
q7	979	802	654	654
q8	9350	1479	1104	1104
q9	7343	5379	5320	5320
q10	6872	2207	1778	1778
q11	506	309	283	283
q12	378	385	238	238
q13	17787	3722	3062	3062
q14	226	242	220	220
q15	602	510	512	510
q16	886	879	802	802
q17	691	809	542	542
q18	7499	7104	7174	7104
q19	1101	969	607	607
q20	372	362	237	237
q21	4299	3368	2549	2549
q22	1068	1015	962	962
Total cold run time: 108827 ms
Total hot run time: 34469 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4953	4901	4907	4901
q2	331	425	309	309
q3	2130	2712	2292	2292
q4	1326	1771	1282	1282
q5	4323	4583	4487	4487
q6	225	180	133	133
q7	2073	1973	1852	1852
q8	2677	2634	2567	2567
q9	7533	7618	7584	7584
q10	3095	3301	2821	2821
q11	601	541	551	541
q12	804	724	621	621
q13	3478	3939	3274	3274
q14	292	318	277	277
q15	541	514	501	501
q16	904	905	883	883
q17	1222	1529	1533	1529
q18	7928	7787	7618	7618
q19	850	860	852	852
q20	2013	1990	1996	1990
q21	4668	4323	4121	4121
q22	1069	1025	991	991
Total cold run time: 53036 ms
Total hot run time: 51426 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 182156 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 802495a3d1778f5f3b2aa33382c9ac749c67b747, data reload: false

query1	1058	422	399	399
query2	6569	1165	1143	1143
query3	6742	239	220	220
query4	25241	23276	23063	23063
query5	4885	647	501	501
query6	352	245	238	238
query7	4665	514	314	314
query8	312	256	250	250
query9	8729	2628	2642	2628
query10	551	383	321	321
query11	15548	14847	14520	14520
query12	176	122	120	120
query13	1711	601	463	463
query14	9388	5977	6063	5977
query15	216	204	194	194
query16	7618	710	562	562
query17	1227	805	657	657
query18	2046	442	352	352
query19	226	218	183	183
query20	133	131	122	122
query21	222	140	117	117
query22	3881	3927	3823	3823
query23	33293	32210	32240	32210
query24	8497	2457	2418	2418
query25	653	562	491	491
query26	1253	297	171	171
query27	2708	502	349	349
query28	4339	2192	2161	2161
query29	826	654	522	522
query30	314	234	217	217
query31	823	704	639	639
query32	90	81	80	80
query33	626	404	339	339
query34	846	929	538	538
query35	796	855	746	746
query36	880	945	842	842
query37	125	112	87	87
query38	3893	3856	3751	3751
query39	1472	1396	1396	1396
query40	222	129	121	121
query41	68	66	63	63
query42	131	114	112	112
query43	438	445	433	433
query44	1326	775	766	766
query45	197	196	184	184
query46	909	1015	651	651
query47	1703	1740	1678	1678
query48	408	422	326	326
query49	776	502	397	397
query50	690	718	410	410
query51	3860	4046	3791	3791
query52	116	112	104	104
query53	243	262	193	193
query54	317	296	284	284
query55	98	95	89	89
query56	337	327	316	316
query57	1143	1166	1088	1088
query58	292	284	274	274
query59	2341	2429	2347	2347
query60	361	352	383	352
query61	173	166	172	166
query62	797	719	654	654
query63	229	190	196	190
query64	4573	1232	920	920
query65	4053	3994	3969	3969
query66	1127	434	342	342
query67	15083	14850	14842	14842
query68	8473	995	640	640
query69	523	344	313	313
query70	1123	1011	1016	1011
query71	484	338	314	314
query72	5832	4935	5014	4935
query73	736	591	346	346
query74	8719	8810	8564	8564
query75	3602	3041	2580	2580
query76	3689	1145	728	728
query77	819	420	325	325
query78	9515	9530	8852	8852
query79	2202	852	611	611
query80	657	609	496	496
query81	500	270	245	245
query82	462	138	118	118
query83	305	272	247	247
query84	308	116	98	98
query85	943	510	461	461
query86	345	315	298	298
query87	4081	4061	3968	3968
query88	3478	2264	2271	2264
query89	399	329	303	303
query90	2000	229	217	217
query91	178	173	145	145
query92	86	70	69	69
query93	1229	1037	680	680
query94	732	460	349	349
query95	519	423	406	406
query96	541	554	288	288
query97	2667	2680	2607	2607
query98	238	218	212	212
query99	1409	1398	1280	1280
Total cold run time: 271735 ms
Total hot run time: 182156 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.39 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 802495a3d1778f5f3b2aa33382c9ac749c67b747, data reload: false

query1	0.06	0.05	0.04
query2	0.10	0.05	0.04
query3	0.26	0.09	0.08
query4	1.61	0.11	0.11
query5	0.28	0.26	0.26
query6	1.17	0.65	0.66
query7	0.04	0.03	0.03
query8	0.06	0.04	0.04
query9	0.58	0.51	0.50
query10	0.56	0.56	0.55
query11	0.16	0.11	0.11
query12	0.15	0.13	0.11
query13	0.62	0.63	0.61
query14	0.99	0.97	0.98
query15	0.82	0.80	0.80
query16	0.40	0.41	0.40
query17	1.01	1.06	1.05
query18	0.23	0.21	0.22
query19	1.96	1.86	1.85
query20	0.02	0.01	0.01
query21	15.45	0.27	0.13
query22	4.89	0.06	0.04
query23	16.10	0.27	0.10
query24	1.80	0.63	0.32
query25	0.08	0.06	0.08
query26	0.13	0.13	0.14
query27	0.06	0.06	0.05
query28	3.63	1.24	1.02
query29	12.54	4.01	3.21
query30	0.27	0.14	0.13
query31	2.81	0.63	0.39
query32	3.24	0.56	0.46
query33	3.15	3.03	3.08
query34	16.66	5.21	4.48
query35	4.59	4.59	4.58
query36	0.68	0.50	0.49
query37	0.10	0.07	0.06
query38	0.07	0.04	0.05
query39	0.05	0.03	0.03
query40	0.17	0.14	0.13
query41	0.08	0.04	0.03
query42	0.05	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 97.72 s
Total hot run time: 27.39 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants