Skip to content

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Dec 3, 2025

What problem does this PR solve?

SELECT avg((ss_quantity * ss_list_price)) average_sales from store_sales;

before:
partial_avg(CAST((CAST(ss_quantity[#23] AS decimalv3(10,0)) * ss_list_price[#24]) AS decimalv3(19,4)))[#25]
doris 28.42 sec
doris disable check 25.17 sec

after:
partial_avg((CAST(ss_quantity[#23] AS decimalv3(10,0)) * ss_list_price[#24]))[#25]
doris 19.14 sec
doris disable check 17.12 sec

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.45% (18696/34977)
Line Coverage 39.09% (172589/441483)
Region Coverage 33.71% (133654/396452)
Branch Coverage 34.66% (57505/165927)

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

update

fix

fix

fix

fix

fix
@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 45.45% (15/33) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.36% (18638/34930)
Line Coverage 39.01% (172072/441053)
Region Coverage 33.63% (133226/396158)
Branch Coverage 34.59% (57330/165763)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 90.91% (30/33) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.15% (24710/34247)
Line Coverage 58.83% (259253/440661)
Region Coverage 53.73% (215449/400969)
Branch Coverage 55.24% (92067/166660)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 45.45% (15/33) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.39% (18651/34933)
Line Coverage 39.04% (172207/441079)
Region Coverage 33.65% (133354/396324)
Branch Coverage 34.61% (57389/165808)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 90.91% (30/33) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.20% (24730/34250)
Line Coverage 58.89% (259503/440689)
Region Coverage 53.74% (215561/401138)
Branch Coverage 55.29% (92178/166707)

morrySnow
morrySnow previously approved these changes Dec 4, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

PR approved by anyone and no changes requested.

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants