-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature](runtime-filter) support rf on set operator: be part #49679
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
run beut |
: RuntimeFilterWrapper::State::READY; | ||
if (!wake_up_early) { | ||
// Hash table is completed and runtime filter has a global size now. | ||
uint64_t hash_table_size = block ? block->rows() : 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why use set hash table size. more correct
return Status::OK(); | ||
} | ||
|
||
if (!_runtime_filter_producer_helper || state->is_cancelled() || !_eos) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (_runtime_filter_producer_helper && state->ok() && _eos) {
try {
RETURN_IF_ERROR(
_runtime_filter_producer_helper->process(state, &_shared_state->build_block));
} catch (Exception& e) {
return Status::InternalError(
"rf process meet error: {}, wake_up_early: {}, _finish_dependency: {}",
e.to_string(), state->get_task()->wake_up_early(),
_finish_dependency->debug_string());
}
}
return Base::close(state, exec_status);
fix update fix
run buildall |
What problem does this PR solve?
support rf on set operator: be part
part of #49573
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)