-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](Compaction) atomic should not be implicitly converted to int64_t #49427
[Fix](Compaction) atomic should not be implicitly converted to int64_t #49427
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 34082 ms
|
TPC-DS: Total hot run time: 193942 ms
|
ClickBench: Total hot run time: 30.87 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Please add a description for this PR. |
#49427) atomic<int64_t> cannot be implicitly converted to int64_t, which may lead to data errors in high concurrency situations.
#49427) atomic<int64_t> cannot be implicitly converted to int64_t, which may lead to data errors in high concurrency situations.
…ed to int64_t #49427 (#49448) Cherry-picked from #49427 Co-authored-by: abmdocrt <[email protected]>
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
atomic<int64_t> cannot be implicitly converted to int64_t, which may lead to data errors in high concurrency situations.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)