-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat](nereids) support show tablets from table command #49426
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
run buildall |
TPC-H: Total hot run time: 34416 ms
|
TPC-DS: Total hot run time: 187486 ms
|
ClickBench: Total hot run time: 31.18 s
|
|
||
return new ShowResultSet(getMetaData(), rows); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need override toRedirectStatus
|
||
return new ShowResultSet(getMetaData(), rows); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need override toRedirectStatus
} | ||
|
||
if (whereClause != null) { | ||
boolean valid = whereClause.accept(new DefaultExpressionVisitor<Boolean, Void>() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need to use visitor, you can take https://github.com/apache/doris/pull/44279/files as reference
public ShowResultSetMetaData getMetaData() { | ||
ShowResultSetMetaData.Builder builder = ShowResultSetMetaData.builder(); | ||
for (String title : TabletsProcDir.TITLE_NAMES) { | ||
builder.addColumn(new Column(title, ScalarType.createVarchar(30))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use longer length for safety like ScalarType.createVarchar(128)
run buildall |
run buildall |
TPC-H: Total hot run time: 34348 ms
|
TPC-DS: Total hot run time: 193450 ms
|
ClickBench: Total hot run time: 31.34 s
|
run p0 |
run vault_p0 |
run p0 |
run arm |
run buildall |
TPC-H: Total hot run time: 34269 ms
|
TPC-DS: Total hot run time: 187089 ms
|
ClickBench: Total hot run time: 31.08 s
|
run vault_p0 |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
What problem does this PR solve?
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)