Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](Variant) return status if dict key not found when sync_tablet_rowsets #49417

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Mar 24, 2025

If meta service version is old, then there's chance to return response that the new version of BE can not handle

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…rowsets`

If meta service version is old, then there's chance to return response that the new version of BE can not handle
@eldenmoon
Copy link
Member Author

run buildall

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TPC-H: Total hot run time: 34138 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit af977c124c1e33ff597b583713efac330ccd8e78, data reload: false

------ Round 1 ----------------------------------
q1	26122	5062	5006	5006
q2	2070	283	160	160
q3	10424	1221	691	691
q4	10231	1009	524	524
q5	7523	2359	2321	2321
q6	188	160	134	134
q7	912	728	608	608
q8	9315	1206	1109	1109
q9	6852	5103	5122	5103
q10	6877	2299	1872	1872
q11	481	288	258	258
q12	355	356	219	219
q13	17779	3996	3067	3067
q14	231	242	222	222
q15	544	500	494	494
q16	635	623	581	581
q17	585	851	352	352
q18	7462	7279	7192	7192
q19	1482	952	563	563
q20	309	328	193	193
q21	3910	2810	2526	2526
q22	1028	1031	943	943
Total cold run time: 115315 ms
Total hot run time: 34138 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5160	5084	5129	5084
q2	241	326	230	230
q3	2149	2622	2263	2263
q4	1447	1777	1366	1366
q5	4426	4371	4373	4371
q6	217	166	130	130
q7	1966	1908	1779	1779
q8	2563	2566	2519	2519
q9	7270	7227	6969	6969
q10	3038	3202	2753	2753
q11	555	504	483	483
q12	689	765	629	629
q13	3507	3915	3324	3324
q14	286	315	293	293
q15	531	484	475	475
q16	657	687	641	641
q17	1141	1572	1394	1394
q18	7819	7642	7540	7540
q19	849	839	880	839
q20	1921	1990	1834	1834
q21	5391	4892	4855	4855
q22	1109	1043	1015	1015
Total cold run time: 52932 ms
Total hot run time: 50786 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193925 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit af977c124c1e33ff597b583713efac330ccd8e78, data reload: false

query1	1423	1058	1070	1058
query2	6156	1970	1935	1935
query3	11003	4498	4645	4498
query4	25915	23776	23420	23420
query5	4832	625	459	459
query6	302	192	196	192
query7	3982	498	271	271
query8	311	275	244	244
query9	8548	2616	2599	2599
query10	491	288	251	251
query11	15409	15112	14844	14844
query12	163	117	113	113
query13	1567	508	384	384
query14	9182	6126	6014	6014
query15	195	194	166	166
query16	7381	636	481	481
query17	1122	732	593	593
query18	1992	417	309	309
query19	193	193	157	157
query20	118	121	121	121
query21	211	122	104	104
query22	4545	4523	4310	4310
query23	34255	33741	33455	33455
query24	8471	2483	2478	2478
query25	540	489	439	439
query26	1195	275	148	148
query27	3022	511	329	329
query28	4510	2447	2413	2413
query29	710	576	476	476
query30	280	222	195	195
query31	938	898	812	812
query32	73	69	64	64
query33	539	371	306	306
query34	789	923	507	507
query35	818	841	795	795
query36	984	1041	930	930
query37	115	111	77	77
query38	4242	4137	4427	4137
query39	1488	1460	1449	1449
query40	205	113	105	105
query41	54	57	53	53
query42	127	105	104	104
query43	517	529	483	483
query44	1308	821	820	820
query45	182	181	168	168
query46	845	1033	644	644
query47	1861	1879	1790	1790
query48	388	414	311	311
query49	769	542	445	445
query50	708	762	437	437
query51	4266	4279	4304	4279
query52	118	111	103	103
query53	236	260	191	191
query54	533	524	429	429
query55	84	84	84	84
query56	289	289	277	277
query57	1182	1201	1125	1125
query58	265	253	255	253
query59	2759	2917	2764	2764
query60	301	309	289	289
query61	176	154	176	154
query62	798	765	690	690
query63	233	189	183	183
query64	4193	1104	698	698
query65	4705	4467	4466	4466
query66	1018	399	296	296
query67	16511	15579	15518	15518
query68	9676	818	498	498
query69	484	298	257	257
query70	1249	1112	1107	1107
query71	467	306	267	267
query72	5219	5064	5025	5025
query73	722	580	344	344
query74	9136	9053	9014	9014
query75	4425	3306	2746	2746
query76	4981	1208	755	755
query77	1004	378	293	293
query78	9904	10305	9286	9286
query79	2402	812	568	568
query80	680	510	449	449
query81	484	260	218	218
query82	243	128	95	95
query83	201	177	157	157
query84	285	104	78	78
query85	752	355	304	304
query86	341	308	285	285
query87	4483	4538	4406	4406
query88	2852	2219	2217	2217
query89	421	308	278	278
query90	2139	208	209	208
query91	140	145	109	109
query92	79	64	53	53
query93	2062	1057	566	566
query94	673	405	296	296
query95	357	270	271	270
query96	492	566	277	277
query97	3241	3450	3273	3273
query98	233	198	202	198
query99	1371	1397	1336	1336
Total cold run time: 283839 ms
Total hot run time: 193925 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.12 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit af977c124c1e33ff597b583713efac330ccd8e78, data reload: false

query1	0.05	0.04	0.04
query2	0.12	0.11	0.10
query3	0.26	0.18	0.19
query4	1.59	0.19	0.19
query5	0.60	0.58	0.58
query6	1.21	0.70	0.71
query7	0.03	0.02	0.02
query8	0.04	0.04	0.04
query9	0.58	0.52	0.52
query10	0.58	0.60	0.58
query11	0.16	0.11	0.10
query12	0.15	0.12	0.11
query13	0.62	0.61	0.60
query14	2.66	2.67	2.71
query15	0.92	0.85	0.85
query16	0.37	0.38	0.39
query17	1.03	1.03	1.02
query18	0.21	0.20	0.19
query19	1.91	1.93	1.83
query20	0.01	0.01	0.02
query21	15.36	0.89	0.55
query22	0.76	1.16	0.63
query23	14.99	1.42	0.61
query24	7.43	1.26	0.88
query25	0.46	0.25	0.05
query26	0.58	0.17	0.12
query27	0.06	0.05	0.05
query28	9.81	0.85	0.43
query29	12.57	3.96	3.33
query30	0.24	0.08	0.06
query31	2.84	0.60	0.39
query32	3.23	0.55	0.47
query33	3.10	3.04	3.08
query34	15.67	5.13	4.50
query35	4.51	4.53	4.50
query36	0.67	0.50	0.49
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.09	0.03	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.86 s
Total hot run time: 31.12 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 24, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/13) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 50.23% (13441/26760)
Line Coverage 39.68% (116451/293489)
Region Coverage 38.39% (59187/154174)
Branch Coverage 33.52% (29900/89188)

@gavinchou gavinchou changed the title [Fix](Variant) return status if dict key not found when `sync_tablet_… [Fix](Variant) return status if dict key not found when sync_tablet_rowsets Mar 26, 2025
@eldenmoon eldenmoon merged commit 5b4b121 into apache:master Mar 26, 2025
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.x dev/3.0.x-conflict reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants