Skip to content

[fix](Nereids) use StringLikeLiteral as parameter type in constant folding #49413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

[fix](Nereids) use StringLikeLiteral as parameter type in constant folding #49413

merged 1 commit into from
Mar 25, 2025

Conversation

morrySnow
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #40441

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34321 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 87be276abdc5c1d3bdebbc76e46b9a0e19734769, data reload: false

------ Round 1 ----------------------------------
q1	25954	5072	5016	5016
q2	2061	277	159	159
q3	10409	1244	723	723
q4	10237	990	526	526
q5	7534	2347	2394	2347
q6	187	167	133	133
q7	909	744	612	612
q8	9315	1251	1142	1142
q9	6798	5132	5139	5132
q10	6813	2320	1910	1910
q11	475	278	267	267
q12	347	352	227	227
q13	17754	3658	3114	3114
q14	240	230	207	207
q15	537	474	472	472
q16	622	614	581	581
q17	577	867	349	349
q18	7587	7323	7148	7148
q19	1233	951	563	563
q20	335	326	197	197
q21	4067	2742	2519	2519
q22	1055	1022	977	977
Total cold run time: 115046 ms
Total hot run time: 34321 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5143	5094	5102	5094
q2	245	336	232	232
q3	2154	2615	2286	2286
q4	1398	1797	1392	1392
q5	4459	4413	4406	4406
q6	216	168	131	131
q7	1976	1948	1757	1757
q8	2585	2473	2493	2473
q9	7352	7334	7124	7124
q10	3042	3228	2754	2754
q11	581	525	504	504
q12	705	778	632	632
q13	3603	3954	3376	3376
q14	296	328	291	291
q15	546	487	490	487
q16	688	696	642	642
q17	1158	1592	1374	1374
q18	7829	7785	7901	7785
q19	841	876	865	865
q20	1946	2019	1956	1956
q21	5549	5019	4925	4925
q22	1114	1041	1017	1017
Total cold run time: 53426 ms
Total hot run time: 51503 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193711 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 87be276abdc5c1d3bdebbc76e46b9a0e19734769, data reload: false

query1	1417	1059	1086	1059
query2	6323	1980	1990	1980
query3	12316	4671	4695	4671
query4	27221	23892	23207	23207
query5	5405	677	485	485
query6	305	199	193	193
query7	3977	485	264	264
query8	290	229	226	226
query9	8518	2570	2572	2570
query10	487	316	259	259
query11	15511	15057	14939	14939
query12	166	117	109	109
query13	1568	527	408	408
query14	9404	6137	6266	6137
query15	203	195	162	162
query16	7608	640	466	466
query17	1158	760	596	596
query18	2016	426	322	322
query19	207	202	164	164
query20	138	131	125	125
query21	209	127	109	109
query22	4645	4537	4352	4352
query23	34491	33884	33362	33362
query24	8496	2450	2422	2422
query25	522	466	403	403
query26	1213	272	146	146
query27	2811	497	327	327
query28	4769	2435	2406	2406
query29	687	569	436	436
query30	277	225	199	199
query31	923	891	799	799
query32	72	67	61	61
query33	542	401	326	326
query34	777	896	498	498
query35	833	853	778	778
query36	993	1018	922	922
query37	118	106	76	76
query38	4264	4144	4208	4144
query39	1487	1445	1465	1445
query40	218	121	106	106
query41	52	53	52	52
query42	123	103	110	103
query43	524	523	495	495
query44	1358	812	823	812
query45	186	183	176	176
query46	864	1048	626	626
query47	1828	1870	1854	1854
query48	394	421	319	319
query49	797	498	429	429
query50	703	761	419	419
query51	4283	4352	4305	4305
query52	106	109	96	96
query53	228	274	189	189
query54	507	520	421	421
query55	83	81	80	80
query56	274	279	262	262
query57	1217	1200	1129	1129
query58	259	255	248	248
query59	2754	3050	2662	2662
query60	300	272	261	261
query61	128	128	166	128
query62	747	756	670	670
query63	218	184	182	182
query64	4016	1057	709	709
query65	4701	4509	4496	4496
query66	952	402	323	323
query67	16350	15549	15368	15368
query68	9761	898	498	498
query69	475	300	262	262
query70	1172	1135	1116	1116
query71	478	302	259	259
query72	5528	5140	5263	5140
query73	734	617	344	344
query74	8992	9163	9005	9005
query75	4371	3229	2723	2723
query76	4131	1205	758	758
query77	914	350	286	286
query78	9866	10233	9312	9312
query79	1932	819	551	551
query80	655	619	438	438
query81	487	263	222	222
query82	459	126	103	103
query83	212	172	160	160
query84	278	92	79	79
query85	747	353	315	315
query86	328	279	277	277
query87	4425	4443	4375	4375
query88	2868	2240	2237	2237
query89	429	318	273	273
query90	1956	210	219	210
query91	138	139	111	111
query92	79	61	55	55
query93	1311	1019	583	583
query94	683	421	309	309
query95	361	279	256	256
query96	484	562	281	281
query97	3296	3433	3238	3238
query98	224	206	200	200
query99	1450	1415	1262	1262
Total cold run time: 285761 ms
Total hot run time: 193711 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.75 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 87be276abdc5c1d3bdebbc76e46b9a0e19734769, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.10	0.10
query3	0.25	0.19	0.18
query4	1.60	0.20	0.12
query5	0.55	0.53	0.54
query6	1.18	0.72	0.73
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.60	0.52	0.51
query10	0.60	0.59	0.58
query11	0.15	0.11	0.10
query12	0.14	0.12	0.11
query13	0.62	0.60	0.60
query14	2.69	2.71	2.76
query15	0.94	0.86	0.87
query16	0.39	0.38	0.39
query17	1.03	1.05	1.01
query18	0.21	0.20	0.19
query19	2.03	1.84	1.88
query20	0.01	0.01	0.01
query21	15.36	0.92	0.55
query22	0.76	1.24	0.68
query23	14.89	1.42	0.64
query24	7.06	1.05	0.48
query25	0.50	0.18	0.08
query26	0.67	0.17	0.13
query27	0.06	0.05	0.05
query28	8.66	0.96	0.45
query29	12.53	3.95	3.29
query30	0.25	0.09	0.06
query31	2.84	0.59	0.38
query32	3.23	0.56	0.47
query33	3.10	3.07	3.17
query34	15.57	5.10	4.49
query35	4.57	4.53	4.49
query36	0.66	0.50	0.49
query37	0.08	0.06	0.07
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.18	0.13	0.14
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.43 s
Total hot run time: 30.75 s

@morrySnow morrySnow added the p0_b label Mar 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 2ad8108 into apache:master Mar 25, 2025
28 of 30 checks passed
@morrySnow morrySnow deleted the fix_string_fold_not_work branch March 25, 2025 04:22
github-actions bot pushed a commit that referenced this pull request Mar 25, 2025
@morrySnow
[fix](Nereids) use StringLikeLiteral as parameter type in constant fo…
c0b1a5a 
…lding (#49413)

Related PR: #40441
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Mar 25, 2025
@morrySnow
[fix](Nereids) use StringLikeLiteral as parameter type in constant fo…
571f906 
…lding (#49413)

Related PR: #40441
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Merged
yiguolei pushed a commit that referenced this pull request Mar 26, 2025
@morrySnow @yiguolei
[fix](Nereids) use StringLikeLiteral as parameter type in constant fo…
7d939e6 
…lding (#49413)

Related PR: #40441
yiguolei pushed a commit that referenced this pull request Mar 29, 2025
@github-actions @morrySnow
branch-2.1: [fix](Nereids) use StringLikeLiteral as parameter type in…
646f49f 
… constant folding #49413 (#49447)

Cherry-picked from #49413

Co-authored-by: morrySnow <[email protected]>
dataroaring pushed a commit that referenced this pull request Mar 30, 2025
@github-actions @morrySnow
branch-3.0: [fix](Nereids) use StringLikeLiteral as parameter type in…
e26bac2 
… constant folding #49413 (#49446)

Cherry-picked from #49413

Co-authored-by: morrySnow <[email protected]>
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Open
@yiguolei yiguolei mentioned this pull request May 13, 2025
Open
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@morrySnow @koarz
[fix](Nereids) use StringLikeLiteral as parameter type in constant fo…
bacb673 
…lding (apache#49413)

Related PR: apache#40441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 approved these changes

+1 more reviewer

@LiBinfeng-01 LiBinfeng-01 LiBinfeng-01 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.10-merged dev/3.0.5-merged p0_b reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@morrySnow @doris-robot @starocean999 @LiBinfeng-01 @yiguolei @dataroaring