Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](paimon) avoid get paimon table when replay #48152

Open
wants to merge 3 commits into
base: branch-3.0
Choose a base branch
from

Conversation

morningman
Copy link
Contributor

What problem does this PR solve?

catalog.getPaimonTable(dbName, name); will try forward request to master FE.
When in replay logic, forwarding will fail, cause fe failed to start.
Introduced from #43959

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@morningman
Copy link
Contributor Author

run buildall

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 82.36% (1060/1287)
Line Coverage: 65.92% (17569/26653)
Region Coverage: 65.41% (8657/13234)
Branch Coverage: 55.34% (4670/8438)
Coverage Report: http://coverage.selectdb-in.cc/coverage/65e6204c9464781fbb92b5a6600bed21df8a7cb9_65e6204c9464781fbb92b5a6600bed21df8a7cb9_cloud/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 40656 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 65e6204c9464781fbb92b5a6600bed21df8a7cb9, data reload: false

------ Round 1 ----------------------------------
q1	17567	7330	7194	7194
q2	2054	178	170	170
q3	10539	1065	1107	1065
q4	10435	718	769	718
q5	7760	2842	2775	2775
q6	237	147	145	145
q7	967	602	603	602
q8	9357	1936	2022	1936
q9	6542	6378	6372	6372
q10	7034	2294	2317	2294
q11	466	258	269	258
q12	395	206	215	206
q13	17782	2973	3027	2973
q14	231	206	219	206
q15	574	511	534	511
q16	675	601	590	590
q17	974	582	515	515
q18	7263	6645	6766	6645
q19	1440	1079	1096	1079
q20	454	205	195	195
q21	3969	3301	3241	3241
q22	1124	993	966	966
Total cold run time: 107839 ms
Total hot run time: 40656 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7222	7157	7153	7153
q2	327	238	231	231
q3	2926	2884	2861	2861
q4	2042	1799	1774	1774
q5	5707	5709	5693	5693
q6	224	138	138	138
q7	2225	1825	1811	1811
q8	3360	3525	3489	3489
q9	8808	8841	8841	8841
q10	3592	3550	3583	3550
q11	602	498	504	498
q12	808	637	587	587
q13	10977	3178	3137	3137
q14	307	291	266	266
q15	571	521	514	514
q16	690	660	661	660
q17	1840	1608	1587	1587
q18	8124	7794	7872	7794
q19	1653	1495	1617	1495
q20	2064	1859	1846	1846
q21	5428	5458	5306	5306
q22	1106	1048	1052	1048
Total cold run time: 70603 ms
Total hot run time: 60279 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198699 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 65e6204c9464781fbb92b5a6600bed21df8a7cb9, data reload: false

query1	1289	919	897	897
query2	6219	1986	2018	1986
query3	10808	4184	4255	4184
query4	62766	33854	24011	24011
query5	5198	463	471	463
query6	332	189	181	181
query7	4915	316	314	314
query8	280	223	223	223
query9	6649	2717	2713	2713
query10	429	270	256	256
query11	15778	15244	15723	15244
query12	163	103	103	103
query13	1079	441	439	439
query14	10891	7164	7349	7164
query15	207	177	181	177
query16	6772	477	476	476
query17	1207	579	584	579
query18	1522	323	326	323
query19	218	166	164	164
query20	121	117	112	112
query21	217	110	105	105
query22	4921	4679	4649	4649
query23	34634	34470	34249	34249
query24	6380	3003	2963	2963
query25	548	430	427	427
query26	659	178	170	170
query27	1828	364	360	360
query28	4143	2514	2445	2445
query29	712	445	432	432
query30	249	164	160	160
query31	963	819	806	806
query32	67	54	58	54
query33	468	285	298	285
query34	892	514	531	514
query35	866	753	723	723
query36	1082	958	975	958
query37	115	78	70	70
query38	4121	3952	4025	3952
query39	1543	1441	1461	1441
query40	197	99	95	95
query41	50	47	47	47
query42	118	99	100	99
query43	523	488	504	488
query44	1190	843	850	843
query45	178	169	170	169
query46	1134	719	737	719
query47	2026	1985	1961	1961
query48	479	415	393	393
query49	709	398	388	388
query50	863	423	429	423
query51	7262	7256	7259	7256
query52	102	97	90	90
query53	265	188	183	183
query54	579	460	469	460
query55	74	78	78	78
query56	277	260	264	260
query57	1314	1184	1190	1184
query58	222	203	209	203
query59	3192	2947	2809	2809
query60	283	250	249	249
query61	134	185	104	104
query62	819	731	706	706
query63	215	183	187	183
query64	1306	668	667	667
query65	3262	3192	3210	3192
query66	698	293	300	293
query67	15910	15595	15667	15595
query68	3258	622	597	597
query69	423	269	264	264
query70	1175	1127	1135	1127
query71	377	259	249	249
query72	6267	3988	3954	3954
query73	756	352	369	352
query74	10130	9383	9030	9030
query75	3356	2642	2662	2642
query76	1584	1091	1164	1091
query77	491	271	268	268
query78	10744	9630	9615	9615
query79	1393	606	600	600
query80	842	435	423	423
query81	524	239	239	239
query82	1310	120	119	119
query83	240	147	137	137
query84	290	77	80	77
query85	900	306	288	288
query86	330	285	299	285
query87	4424	4384	4244	4244
query88	3872	2404	2372	2372
query89	421	300	302	300
query90	1986	181	183	181
query91	180	148	163	148
query92	64	48	52	48
query93	2009	556	564	556
query94	733	277	274	274
query95	356	258	261	258
query96	604	297	278	278
query97	3288	3156	3249	3156
query98	212	233	202	202
query99	1913	1434	1416	1416
Total cold run time: 309084 ms
Total hot run time: 198699 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.34 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 65e6204c9464781fbb92b5a6600bed21df8a7cb9, data reload: false

query1	0.03	0.02	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.11
query5	0.54	0.50	0.51
query6	1.14	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.03	0.03
query9	0.56	0.48	0.51
query10	0.55	0.56	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.60	0.59
query14	2.76	2.80	2.85
query15	0.90	0.83	0.81
query16	0.41	0.38	0.39
query17	1.05	1.05	1.09
query18	0.24	0.22	0.21
query19	1.95	1.89	2.02
query20	0.02	0.01	0.02
query21	15.36	0.58	0.57
query22	2.66	2.23	1.14
query23	17.03	0.96	0.85
query24	3.41	1.16	1.19
query25	0.22	0.07	0.17
query26	0.48	0.13	0.13
query27	0.05	0.04	0.06
query28	10.56	1.08	1.07
query29	12.58	3.28	3.24
query30	0.25	0.06	0.07
query31	2.85	0.38	0.38
query32	3.25	0.46	0.46
query33	3.00	2.98	3.07
query34	17.06	4.50	4.43
query35	4.56	4.50	4.49
query36	0.67	0.48	0.51
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.17	0.13	0.13
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.49 s
Total hot run time: 32.34 s

@dataroaring
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 82.36% (1060/1287)
Line Coverage: 65.94% (17576/26653)
Region Coverage: 65.44% (8660/13234)
Branch Coverage: 55.34% (4670/8438)
Coverage Report: http://coverage.selectdb-in.cc/coverage/da52b309518c3a98d628150813b3c66ae73cbf42_da52b309518c3a98d628150813b3c66ae73cbf42_cloud/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants