Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement-16534][Master] switch task doesn't support includes method #16594

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

[Improvement-16534][Master] switch task doesn't support includes method #16594

wants to merge 4 commits into from
+15 −0

Conversation

ChaoquanTao
Copy link
Contributor

@ChaoquanTao ChaoquanTao commented Sep 6, 2024 •
edited by SbloodyS
Loading

Purpose of the pull request

This PR add polyfill for js engine to support includes method. fix #16534

Brief change log

  • modify SwtichTaskUtils to support includes method

Verify this pull request

This change added tests and can be verified as follows:

  • Added SwitchTaskUtilsTest#testIncludes to verify the change.

(or)

Pull Request Notice

@SbloodyS SbloodyS added this to the 3.3.0 milestone Sep 6, 2024
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Sep 6, 2024
SbloodyS
SbloodyS reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run mvn spotless:apply to format the code.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 7, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SbloodyS SbloodyS SbloodyS left review comments

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@ChaoquanTao ChaoquanTao

Labels
backend improvement make more easy to user or prompt friendly test
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

[Improvement][Master] switch task doesn't support includes function
3 participants
@ChaoquanTao @SbloodyS @taochaoquan-bosch