[Fix-16567] Unable to delete copied nodes in unsaved workflow #16576
Conversation
…rray 2. If the dependent Lineage Task List is empty, no further query is required
Xuxiaotuan
requested review from
songjianet,
SbloodyS and
caishunfeng
as code owners
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
SbloodyS
changed the title
SbloodyS
added
first time contributor
|
Read the wrong message is: " Error: The archive file /home/runner/.m2/repository/com/github/eirslett/node/16.13.1/node-16.13.1-linux-x64.tar.gz is corrupted and will be deleted. Please try the build again." CI may need to be executed again, and Quality Gate failure I don't know what to do with this |
| (item: any) => item.processDefinitionCode !== workflowCode | ||
| ) | ||
| .forEach((item: any) => { | ||
| tasks.push( | ||
| item.processDefinitionName + '->' + item.taskDefinitionName |
There was a problem hiding this comment.
| (item: any) => item.processDefinitionCode !== workflowCode | |
| ) | |
| .forEach((item: any) => { | |
| tasks.push( | |
| item.processDefinitionName + '->' + item.taskDefinitionName | |
| (item: any) => item.workflowDefinitionCode !== workflowCode | |
| ) | |
| .forEach((item: any) => { | |
| tasks.push( | |
| item.workflowDefinitionName + '->' + item.taskDefinitionName |
Node related error are caused by network fluctuations, and you don't need to care about |
…/use-dependencies.ts fix Co-authored-by: xiangzihao <[email protected]>
# Conflicts: # dolphinscheduler-ui/src/views/projects/components/dependencies/use-dependencies.ts
|
The front-end and code standards, along with the suggestions for modification, have been revised. Assistance is needed to execute the CI @SbloodyS |
This still unaddressed. #16576 (comment) |
…efinitionCode、workflowDefinitionName
I didn't notice, there was a PR that had already changed the field name, I have revised and resubmitted it. |
There was a problem hiding this comment.
This fix does not address the root cause, which is that the lineage info is not copyed when the workflow is copyed. Would you like to open another PR to fix it? @Xuxiaotuan
This PR is LGTM. Thanks.
|
Please run |
Ok, I will open another PR to solve the root issue. |
|
I don't know how to click on it “dismissed”. I'm sorry. It wasn't my intention |
It wasn't your clicking. Dissmiss will happen every time you repush the code. This is normal in the process of PR repair. |
|
|
Awesome work, congrats on your first merged pull request! |
fix #16567
If a node is copied in an existing workflow, it cannot be deleted without being saved
Purpose of the pull request
Brief change log
Verify this pull request
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md