Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16331] fix the resource file cannot be displayed hierarchically #16336

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

JohnZp
Copy link
Contributor

@JohnZp JohnZp commented Jul 17, 2024

Purpose of the pull request

fix #16331

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@JohnZp JohnZp closed this Jul 17, 2024
@JohnZp JohnZp deleted the fix-16331 branch July 17, 2024 07:25
@JohnZp JohnZp restored the fix-16331 branch July 17, 2024 07:28
@JohnZp JohnZp reopened this Jul 17, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jul 17, 2024
@SbloodyS SbloodyS added the bug Something isn't working label Jul 17, 2024
Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please make the CI happy.

mvn spotless:apply

@JohnZp
Copy link
Contributor Author

JohnZp commented Jul 18, 2024

LGTM, but please make the CI happy.

mvn spotless:apply

Do I need to resubmit?

@SbloodyS
Copy link
Member

Do I need to resubmit?

Yes

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we may have the same folder under different tenant.
e.g.
/dolphinscheduler/tenant1/resources/spark/xx.jar
/dolphinscheduler/tenant2/resources/spark/yy.jar

If we show the folder here, there may exist two spark directory here? this will cause confusion.

@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly and removed bug Something isn't working labels Jul 20, 2024
@SbloodyS
Copy link
Member

SbloodyS commented Sep 5, 2024

e.g.
/dolphinscheduler/tenant1/resources/spark/xx.jar
/dolphinscheduler/tenant2/resources/spark/yy.jar

For this case, I think we can keep tenant1/resources/spark/xx.jar for user is enough.

Are you still working on this? @JohnZp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly
Projects
None yet
4 participants