Array product#22703
Open
SubhamSinghal wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
documentation
Jefffrey
reviewed
Jun 2, 2026
Comment on lines
+158
to
+165
| // Empty list -> multiplicative identity. Distinguished here from | ||
| // all-NULL elements (which yield NULL): we have no data either way, | ||
| // but `[]` is structurally a known-empty product, while `[NULL,NULL]` | ||
| // means every value was unknown. | ||
| if len == 0 { | ||
| builder.append_value(1.0); | ||
| continue; | ||
| } |
Contributor
There was a problem hiding this comment.
What's this behaviour based on? DuckDB seems to output null:
memory D select a, list_product(a) from values ([1]), ([2, 2]), ([1, null]), ([null]), ([]) t(a);
┌───────────┬─────────────────┐
│ a │ list_product(a) │
│ int32[] │ double │
├───────────┼─────────────────┤
│ [1] │ 1.0 │
│ [2, 2] │ 4.0 │
│ [1, NULL] │ 1.0 │
│ [NULL] │ NULL │
│ [] │ NULL │
└───────────┴─────────────────┘
Contributor
Author
There was a problem hiding this comment.
fixed. matched behaviour with duckDB.
| continue; | ||
| } | ||
|
|
||
| let slice = values.slice(start, len); |
Contributor
There was a problem hiding this comment.
I don't think a slice here is strictly necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
yes using UT
Are there any user-facing changes?
Yes — adds two new SQL scalar functions, array_product and its alias list_product. No API breakage.