feat: Add evaluate_to_arrays function #18446
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
EmilyMatt
force-pushed
the
eval-to-arrays
branch
from
b984129 to
ff2f57a
Compare
adriangb
reviewed
Nov 2, 2025
Comment on lines
+103
to
+113
| #[inline] | ||
| pub fn evaluate_expressions_to_arrays( | ||
| exprs: &[Arc<dyn PhysicalExpr>], | ||
| batch: &RecordBatch, | ||
| ) -> Result<Vec<ArrayRef>> { | ||
| let num_rows = batch.num_rows(); | ||
| exprs | ||
| .iter() | ||
| .map(|e| e.evaluate(batch).and_then(|col| col.into_array(num_rows))) | ||
| .collect::<Result<Vec<ArrayRef>>>() | ||
| } |
There was a problem hiding this comment.
Can we handle the footgun of This means that this should not be called on expressions that may return // arrays of different lengths by matching the ColumnarValue and blowing up Scalars, passing through arrays of the same length but erroring if the result is an array of a different length?
Also since this is going to be used pretty widely maybe a docstring example, etc. would help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Reduce code duplication.
What changes are included in this PR?
A util function replacing many calls which are using the same code.
Are these changes tested?
No logic should change whatsoever, so each area which now uses this code should have it's own tests and benchmarks unmodified.
Are there any user-facing changes?
Yes, there is now a new pub function.
No other changes to API.