Change default of AggregateUDFImpl::supports_null_handling_clause to false
#18441
+43
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
IGNORE NULLSandORDER BYon arguments #9924Rationale for this change
Setting a default of
trueis too permissive; we can see it allows specifying it onmedianfor example even though that function doesn't take the config into account. It seems onlyarray_agg,first_valueandlast_valueactually respect the config this setting handles so it makes more sense to make this false by default.What changes are included in this PR?
Change default of
AggregateUDFImpl::supports_null_handling_clausetofalse(fromtrue). Adjustarray_agg,first_valueandlast_valueto implement it astrue.Are these changes tested?
Existing tests, also added a negative case for
median(expect SQL parsing to fail if providing null handling clause).Are there any user-facing changes?
Behaviour change as default of a trait method is changing. Added section to upgrade guide.