Skip to content

Feat: Make current_time aware of execution timezone. #18040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Feat: Make current_time aware of execution timezone. #18040

wants to merge 5 commits into from
+124 −3

Conversation

codetyri0n
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

  • The current_time() function currently uses UTC tz. This PR updates current_time() to use the tz set in 'datafusion.execution.time_zone'

What changes are included in this PR?

  • current_time() returns a tz aware date via the 'datafusion.execution.time_zone' config option.

Are these changes tested?

  • Tested with Datafusion CLI with slt covering popular scenarios added.

@github-actions github-actions bot added documentation Improvements or additions to documentation sqllogictest SQL Logic Tests (.slt) functions Changes to functions implementation labels Oct 13, 2025
@codetyri0n
Copy link
Contributor Author

Could you please take a look to review this and #18034 @Omega359 , thank you.

@codetyri0n
Copy link
Contributor Author

@comphead this is a similar PR to #18034 and have made appropriate changes similar to the ones recommended in #18034
Have also commented out a flaky test in current date slt which was passing a while back.

comphead
comphead reviewed Oct 14, 2025
View reviewed changes
comphead
comphead reviewed Oct 14, 2025
View reviewed changes
datafusion/sqllogictest/test_files/current_time_timezone.slt
SET datafusion.execution.time_zone = '+08:00';

query B
SELECT current_time() = current_time();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking what exactly we testing here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the intention is to have a scenario that has a timezone set with a positive offset from UTC.

@codetyri0n codetyri0n requested a review from comphead October 15, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@comphead comphead Awaiting requested review from comphead

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation functions Changes to functions implementation sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make current_time aware of execution timezone

2 participants

@codetyri0n @comphead