Skip to content

Conversation

kazantsev-maksim
Copy link
Contributor

@kazantsev-maksim kazantsev-maksim commented Oct 11, 2025

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Implement spark bit_not function

Are these changes tested?

Are there any user-facing changes?

Yes, new function on spark crate

@github-actions github-actions bot added the spark label Oct 11, 2025
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kazantsev-maksim btw I cannot find a bit_not Spark function in https://spark.apache.org/docs/latest/api/sql/

@kazantsev-maksim
Copy link
Contributor Author

kazantsev-maksim commented Oct 11, 2025

@comphead
Copy link
Contributor

Right https://spark.apache.org/docs/latest/api/sql/#_22
please add .slt test

@Jefffrey
Copy link
Contributor

I'll pull in my comments from the previous PR (#17155) as it seems it was closed and reopened here:

@kazantsev-maksim
Copy link
Contributor Author

I'll pull in my comments from the previous PR (#17155) as it seems it was closed and reopened here:

Thanks @Jefffrey, renamed func to bitwise_not

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Oct 13, 2025
Copy link
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider adding a roundtrip test (e.g. SELECT bitwise_not(bitwise_not(0)))

But other than the CI failure (looks like fmt issue) this PR looks good to go 👍

@Jefffrey Jefffrey added this pull request to the merge queue Oct 15, 2025
Merged via the queue into apache:main with commit ca3816b Oct 15, 2025
28 checks passed
@Jefffrey
Copy link
Contributor

Thanks @kazantsev-maksim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spark sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[datafusion-spark] Implement Spark bitwise_not function

3 participants