-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Impl spark bit not function #18018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impl spark bit not function #18018
Conversation
# Conflicts: # datafusion/spark/src/function/bitwise/mod.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kazantsev-maksim btw I cannot find a bit_not
Spark function in https://spark.apache.org/docs/latest/api/sql/
Hmm, i find in source code: https://github.com/apache/spark/blob/418cf56ed4dc440b36ebab37d2aac898278215a8/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/bitwiseExpressions.scala#L178 ![]() |
Right https://spark.apache.org/docs/latest/api/sql/#_22 |
I'll pull in my comments from the previous PR (#17155) as it seems it was closed and reopened here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could consider adding a roundtrip test (e.g. SELECT bitwise_not(bitwise_not(0))
)
But other than the CI failure (looks like fmt issue) this PR looks good to go 👍
Thanks @kazantsev-maksim |
Which issue does this PR close?
Part of [EPIC] Complete
datafusion-spark
Spark Compatible Functions #15914.Rationale for this change
What changes are included in this PR?
Implement spark bit_not function
Are these changes tested?
Are there any user-facing changes?
Yes, new function on spark crate