style: simplify some strings for readability #15999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
kosiew
approved these changes
May 9, 2025
|
+1 for better readability. I'm wondering is there any clippy configurations to enforce this style? |
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies string formatting throughout the codebase to improve readability and maintainability by leveraging new string interpolation syntax. Key changes include updating formatting in error messages, debug logs, and println! calls across multiple modules.
Reviewed Changes
Copilot reviewed 178 out of 178 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| datafusion/common/src/dfschema.rs | Simplified qualified name formatting using new interpolation syntax. |
| datafusion/common/src/config.rs | Updated error messages to use new interpolation syntax. |
| datafusion/catalog-listing/src/helpers.rs | Adjusted debug logging string interpolation. |
| datafusion-examples/examples/sql_dialect.rs | Updated println! calls to use the new string interpolation syntax. |
| datafusion-examples/examples/planner_api.rs | Switched formatting in plan printing to the new syntax. |
| datafusion-examples/examples/function_factory.rs | Modified error message in UDAF placeholder parsing using new interpolation syntax. |
| datafusion-examples/examples/expr_api.rs | Simplified assertion messages using new interpolation syntax. |
| datafusion-examples/examples/dataframe.rs | Replaced format! calls in SQL queries with new string interpolation. |
| datafusion-examples/examples/catalog.rs | Updated file creation formatting with new interpolation syntax. |
| datafusion-cli/tests/cli_integration.rs | Transitioned AWS options formatting to use new syntax. |
| datafusion-cli/src/print_options.rs | Updated several writeln! calls to use the new string interpolation syntax for consistency. |
| datafusion-cli/src/pool_type.rs | Adjusted error messages with new interpolation syntax. |
| datafusion-cli/src/main.rs | Revised version printing and file path error messages to use new interpolation syntax. |
| datafusion-cli/src/functions.rs | Updated function display formatting with new interpolation syntax. |
| datafusion-cli/src/exec.rs | Simplified error messages and SQL query formatting with new interpolation syntax. |
| datafusion-cli/src/command.rs | Reformatted SQL commands and error messages using new interpolation syntax. |
| datafusion-cli/src/catalog.rs | Changed expected output formatting using new interpolation syntax. |
| benchmarks/src/util/options.rs | Simplified memory limit error message formatting with new interpolation syntax. |
Thanks!
There is. Since there are already a lot of changes in this pull request, I can look into adding the configuration in a future PR. |
hamirmahal
force-pushed
the
style/simplify-some-strings-for-readability
branch
from
b9e2aa7 to
cc4bd2d
Compare
hamirmahal
force-pushed
the
style/simplify-some-strings-for-readability
branch
from
cc4bd2d to
4275d63
Compare
2010YOUY01
approved these changes
May 11, 2025
|
You’re welcome! |
…trings-for-readability
github-actions
bot
removed
sql
github-actions
bot
removed
physical-expr
|
I merged up from main to resolve some conflicts |
|
Thanks |
brayanjuls
pushed a commit
to brayanjuls/arrow-datafusion
that referenced
this pull request
May 16, 2025
* style: simplify some strings for readability * fix: formatting in `datafusion/` directory * refactor: replace long `format!` string * refactor: replace `format!` with `assert_eq!` --------- Co-authored-by: Andrew Lamb <[email protected]>
jfahne
pushed a commit
to jfahne/datafusion
that referenced
this pull request
May 18, 2025
* style: simplify some strings for readability * fix: formatting in `datafusion/` directory * refactor: replace long `format!` string * refactor: replace `format!` with `assert_eq!` --------- Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The goal of this pull request is to improve code readability and maintainability.
What changes are included in this PR?
This change simplifies some strings in the codebase.
Are these changes tested?
Yes, via CI
Are there any user-facing changes?
No