feat(proto): udf decoding fallback #15997
Open
+96
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
May 8, 2025
There was a problem hiding this comment.
Thank you @leoyvens -- this looks like a nice change to me
I worry that without test coverage we will break the functionality in the future. Is there any way we can add tests that would fail if this code got accidentally broken/reverted in the future?
leoyvens
force-pushed
the
proto-udf-decoding-fallback
branch
from
672b023 to
a3b47fc
Compare
|
@alamb thanks for your review, I've extended a test to cover this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Falls back to the codec hook when the UDF is not present in the
SessionContext.Which issue does this PR close?
Rationale for this change
We need this for more flexible logical plan decoding.
Are these changes tested?
There isn't a lot of test coverage for this code, but there is one test that has a different error message now.
Are there any user-facing changes?
This conservatively avoids any breaking changes for users of
datafusion-proto.