Add PrimitiveDistinctCountGroupsAccumulator
#15985
Open
+352
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub.com:Dandandan/arrow-datafusion into implement_primitive_distinct_groups_accumulator
Dandandan
changed the title
PrimitiveDistinctCountGroupsAccumulatorPrimitiveDistinctCountGroupsAccumulator, speed up PrimitiveDistinctCountAccumulator
Dandandan
force-pushed
the
implement_primitive_distinct_groups_accumulator
branch
from
1738b0b to
a86e804
Compare
Dandandan
changed the title
PrimitiveDistinctCountGroupsAccumulator, speed up PrimitiveDistinctCountAccumulatorPrimitiveDistinctCountGroupsAccumulator
Dandandan
force-pushed
the
implement_primitive_distinct_groups_accumulator
branch
from
cb9cc84 to
a86e804
Compare
Dandandan
force-pushed
the
implement_primitive_distinct_groups_accumulator
branch
from
5e14c73 to
ee69484
Compare
|
This gets a small performance boost on clickbench query 9 (~9% on my end). I am actually wondering if we can do further. I think we could store something like "Obvious" advantage is that we avoid creating many hashsets for high cardinality cases which makes performance and memory usage bad. However it seems kind of tricky of how to integrate it in the current groupsaccumulator setup 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Speed up queries with group by + distinct count, for primitives.
The original code is taken from @waynexia + the change to use
HashTable.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?