WIP: Reduce time spent normalizing #14049
Open
+73
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a Work In Progress 🚨
Which issue does this PR close?
UNION
andORDER BY
queries #13748Rationale for this change
The continued re-normalization of equivalence classes, especially when the number of expressions and number of constants in the sort order is substantial, is very expensive as described on #13748 (comment)
A substantial amount of the planning time for these queries is continually recomputing a normalized version of OrderingEquivalenceClass.
What changes are included in this PR?
Always keep
OrderingEquivalenceClass
normalized (deprecate OrderingEquivalenceClass::normalized_oeq_class)Are these changes tested?
By CI.
Manually testing performance, on datafusion 44:
Currently (Jan 8):
So this is better but still not good enough
Are there any user-facing changes?