MySQL: CREATE INDEx: allow USING clause before ON
#2029
Conversation
| let concurrently = self.parse_keyword(Keyword::CONCURRENTLY); | ||
| let if_not_exists = self.parse_keywords(&[Keyword::IF, Keyword::NOT, Keyword::EXISTS]); | ||
|
|
||
| let mut using = None; |
There was a problem hiding this comment.
Not a fan of this mut but also not a fan of returning a tuple of (index_name, using) at line 7067.
| let concurrently = self.parse_keyword(Keyword::CONCURRENTLY); | ||
| let if_not_exists = self.parse_keywords(&[Keyword::IF, Keyword::NOT, Keyword::EXISTS]); | ||
|
|
||
| let mut using = None; |
| None | ||
| }; | ||
|
|
||
| using = self.parse_optional_using_then_index_type()?.or(using); |
There was a problem hiding this comment.
Should this be something like
using = using.or_else(|| self.parse_optional_using_then_index_type()).transpose()?;in that we should only look to parse again if we didn't parse a value already?
There was a problem hiding this comment.
As Michael pointed out earlier, MySQL does allow having two "USING" clauses. In that case, the second one overwrites the first.
There was a problem hiding this comment.
Might be worth a comment on this line, because at first glance (or if you haven't tried it on MySQL yourself) it does seem backwards 😛
There was a problem hiding this comment.
Ah I see, double checking do the tests include the scenario where two USING clauses are specified? If not we can probably add those
There was a problem hiding this comment.
Good point. Added a second test with two USING clauses. Force-pushed to resolve conflicts and squashed the commits.
iffyio
changed the title
CREATE INDEx: allow USING clause before ON
MohamedAbdeen21
force-pushed
the
main
branch
from
cad1ec4 to
bcc9f7a
Compare
MySQL allows specifying the index type `USING index_type` before the `ON` clause in `CREATE INDEX` statements. This PR allows the `CREATE INDEX` parser to accept both positions of the `USING` clause, regardless of the dialect. docs: https://dev.mysql.com/doc/refman/8.4/en/create-index.html
MohamedAbdeen21
force-pushed
the
main
branch
from
bcc9f7a to
c6a3910
Compare
MySQL allows specifying the index type
USING index_typebefore theONclause inCREATE INDEXstatements.This PR allows the
CREATE INDEXparser to accept both positions of theUSINGclause, regardless of the dialect.docs: https://dev.mysql.com/doc/refman/8.4/en/create-index.html