Postgres constraint NOT VALID and VALIDATE CONSTRAINT #1908
+126
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jun 29, 2025
| @@ -8477,7 +8477,14 @@ impl<'a> Parser<'a> { | |||
| pub fn parse_alter_table_operation(&mut self) -> Result<AlterTableOperation, ParserError> { | |||
| let operation = if self.parse_keyword(Keyword::ADD) { | |||
| if let Some(constraint) = self.parse_optional_table_constraint()? { | |||
| AlterTableOperation::AddConstraint(constraint) | |||
| let mut not_valid = false; | |||
There was a problem hiding this comment.
For both this flag and the new validate constraint clause, can we can skip the dialect methods and have the parser always accept the syntax if it shows up in a statement? since the syntax doesn't look like it conflicts with other dialects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1907
Handles creating constraints with
NOT VALID, as well asALTER TABLE table VALIDATE CONSTRAINT constraint