Skip to content

Conversation

@mbutrovich
Copy link
Contributor

Which issue does this PR close?

N/A.

Rationale for this change

#2528's Iceberg integration needs docs.

What changes are included in this PR?

Add docs for #2528.

How are these changes tested?

N/A.


```shell
$SPARK_HOME/bin/spark-shell \
--packages org.apache.datafusion:comet-spark-spark3.5_2.12:0.12.0,org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:1.8.1,org.apache.iceberg:iceberg-core:1.8.1 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) We don't need org.apache.iceberg:iceberg-core:1.8.1 if org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:1.8.1 is available.

Copy link
Contributor Author

@mbutrovich mbutrovich Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find that to be the case in my testing because Comet relies on classes that are in core and not just runtime, but it's been a few weeks. Have you tested it?

I can test tomorrow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand it correctly, you're talking about the core or api classes you used in IcebergReflection.

jar tf iceberg-spark-runtime-3.5_2.12-1.10.0.jar | grep -E "org.apache.iceberg.ContentScanTask.class|org.apache.iceberg.FileScanTask.class|org.apache.iceberg.ContentFile.class|org.apache.iceberg.StructLike.class|org.apache.iceberg.PartitionScanTask.class|org.apache.iceberg.DeleteFile.class|org.apache.iceberg.expressions.Literal.class|org.apache.iceberg.SchemaParser.class|org.apache.iceberg.Schema.class|org.apache.iceberg.PartitionSpecParser.class|org.apache.iceberg.PartitionSpec.class|org.apache.iceberg.PartitionField.class|org/apache/iceberg/expressions/UnboundPredicate.class"
org/apache/iceberg/PartitionSpecParser.class
org/apache/iceberg/SchemaParser.class
org/apache/iceberg/ContentFile.class
org/apache/iceberg/ContentScanTask.class
org/apache/iceberg/DeleteFile.class
org/apache/iceberg/FileScanTask.class
org/apache/iceberg/PartitionField.class
org/apache/iceberg/PartitionScanTask.class
org/apache/iceberg/PartitionSpec.class
org/apache/iceberg/Schema.class
org/apache/iceberg/StructLike.class
org/apache/iceberg/expressions/Literal.class
org/apache/iceberg/expressions/UnboundPredicate.class

jar can be found from https://mvnrepository.com/artifact/org.apache.iceberg/iceberg-spark-runtime-3.5_2.12/1.10.0

Copy link
Contributor

@hsiang-c hsiang-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbutrovich

@mbutrovich
Copy link
Contributor Author

Thanks for the feedback @hsiang-c and @comphead!

@mbutrovich mbutrovich merged commit 0fec0f5 into apache:main Dec 9, 2025
1 check passed
@mbutrovich mbutrovich deleted the iceberg_docs branch December 9, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants