feat: [branch-0.10] Add dynamic enabled and allowIncompat configs for all supported expressions (#2329)
#2385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rted expressions (apache#2329)
parthchandra
approved these changes
Sep 11, 2025
Yes, I used |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## branch-0.10 #2385 +/- ##
==============================================
Coverage ? 57.62%
Complexity ? 1297
==============================================
Files ? 147
Lines ? 13507
Branches ? 2391
==============================================
Hits ? 7783
Misses ? 4457
Partials ? 1267 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } else { | ||
| checkSparkAnswer(s"SELECT initcap(name) FROM $table") | ||
| } | ||
| checkSparkAnswer(s"SELECT initcap(name) FROM $table") |
There was a problem hiding this comment.
Is #1052
resolved?
If so we should use checkSparkAnswerAndOperator
| @@ -68,15 +68,14 @@ object CometLower extends CometCaseConversionBase[Lower]("lower") | |||
|
|
|||
| object CometInitCap extends CometScalarFunction[InitCap]("initcap") { | |||
|
|
|||
| override def getSupportLevel(expr: InitCap): SupportLevel = { | |||
There was a problem hiding this comment.
Is this really incompatible?
There was a problem hiding this comment.
Yes:
!== Correct Answer - 7 == == Spark Answer - 7 ==
struct<initcap(name):string> struct<initcap(name):string>
[James Smith] [James Smith]
[James Smith] [James Smith]
[James Ähtäri] [James Ähtäri]
[Michael Rose] [Michael Rose]
[Rames Rose] [Rames Rose]
![Robert Rose-smith] [Robert Rose-Smith]
[Robert Williams] [Robert Williams]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Backport of #2329
What changes are included in this PR?
How are these changes tested?