chore: Enable Comet explicitly in CometTPCDSQueryTestSuite
#1559
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1559 +/- ##
============================================
+ Coverage 56.12% 58.39% +2.26%
- Complexity 976 985 +9
============================================
Files 119 122 +3
Lines 11743 12217 +474
Branches 2251 2280 +29
============================================
+ Hits 6591 7134 +543
+ Misses 4012 3951 -61
+ Partials 1140 1132 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
changed the title
CometTPCDSQueryTestSuite
andygrove
commented
Mar 20, 2025
| conf.set(MEMORY_OFFHEAP_ENABLED.key, "true") | ||
| conf.set(MEMORY_OFFHEAP_SIZE.key, "2g") | ||
| conf.set(CometConf.COMET_MEMORY_OVERHEAD.key, "2g") |
There was a problem hiding this comment.
COMET_MEMORY_OVERHEAD is not used in off-heap mode
andygrove
commented
Mar 20, 2025
| @@ -90,10 +90,8 @@ class CometTPCHQuerySuite extends QueryTest with TPCBase with ShimCometTPCHQuery | |||
| conf.set(CometConf.COMET_EXEC_ENABLED.key, "true") | |||
| conf.set(CometConf.COMET_NATIVE_SCAN_ENABLED.key, "true") | |||
| conf.set(CometConf.COMET_EXEC_SHUFFLE_ENABLED.key, "true") | |||
| conf.set(CometConf.COMET_SHUFFLE_MODE.key, "jvm") | |||
There was a problem hiding this comment.
This is unrelated, but there is no reason for us to disable native shuffle now. I can revert this change and move to a separate PR if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Enable Comet support explicitly rather than rely on default setting.
What changes are included in this PR?
How are these changes tested?