Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UI #1072

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Remove UI #1072

merged 1 commit into from
Oct 12, 2024

Conversation

milenkovicm
Copy link
Contributor

As part of effort outlined in #1066 and #1067 this PR removes UI package from core ballista.

Relates to: #1066 & #1067

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@andygrove
Copy link
Member

This looks good. Thanks.

Could you also update the documentation (user guide, contributor guide, etc)?

Here is a partial list of references:

$ find . -name "*.md" -exec grep -Hi "web ui" {} \;
./docs/source/contributors-guide/code-organization.md:- [Web UI](https://github.com/apache/datafusion-ballista/tree/main/ballista/scheduler/ui)
./docs/source/user-guide/introduction.md:![Ballista Scheduler Web UI](./images/ballista-web-ui.png)
./docs/source/user-guide/scheduler.md:![Ballista Scheduler Web UI](./images/ballista-web-ui.png)
./docs/source/user-guide/deployment/docker.md:Starting nginx to serve Ballista Scheduler web UI on port 80
./docs/source/user-guide/deployment/docker-compose.md:The scheduler web UI is available on port 80 in the scheduler.
./CONTRIBUTING.md:- Javascript (Scheduler Web UI)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 11, 2024
@milenkovicm
Copy link
Contributor Author

should be removed now, plus few extra lines i found

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you fix the merge conflict?

@milenkovicm
Copy link
Contributor Author

done

@andygrove
Copy link
Member

Looks like there is still a reference in the docker scripts:

+ cd ballista/scheduler/ui
/home/builder/builder-entrypoint.sh: line 27: cd: ballista/scheduler/ui: No such file or directory

@andygrove andygrove merged commit 37b4b0e into apache:main Oct 12, 2024
15 checks passed
@milenkovicm milenkovicm deleted the reloaded_remove_ui branch November 1, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants