-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create resources for GitHub release backfill #79
Conversation
also clean up some other scripts and add docs
@colearendt I backfilled the releases - thanks for the scripts. However, in doing so we lose the timestamp history for the releases, which I'd like to maintain (particularly in the index yaml). I think this is fixable by setting I also wonder whether we can generate more useful release notes / change logs for each release but perhaps that's a distinct PR. |
I fixed the date of the tags but couldn't find a way to set the release date so I think we'll have to leave it |
Ahh unfortunate. Good catch! Apparently my response to this never got posted. My search turned up empty too 😞 |
It looks like the issue with the timestamp:
I'm still hopeful for the issue here, but as you said, we may just need to sit on what we have for now 😞 |
Nice!! Well done - sorry for missing that! I agree that time stamp preservation would be preferable. I will take a look!
As for release notes, there is a release-notes-file arg to the chart-releaser binary. Is that something you would want to maintain directly, or parse it from a NEWS file or something? And just for go forward releases, or is there something you want to use for the backfill?
On Jun 17, 2022, at 9:07 AM, Will Holley ***@***.***> wrote:
@colearendt<https://github.com/colearendt> I backfilled the releases - thanks for the scripts. However, in doing so we lose the timestamp history for the releases, which I'd like to maintain (particularly in the index yaml). I think this is fixable by setting GIT_COMMITTER_DATE before we create the release tags but I'll need to delete and recreate the releases.
I also wonder whether we can generate more useful release notes / change logs for each release but perhaps that's a distinct PR.
—
Reply to this email directly, view it on GitHub<#79 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFQBVVV2GGPGNFJQFKQT26TVPR2BFANCNFSM5XFSHEDQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
What this PR does / why we need it:
Create the scripts and tooling to support creating GitHub releases with the appropriate chart data, as discussed in #62 . I tested this on my fork (you can see the releases there). It does nothing on its own, and does not help create the index.yaml or the repo proper. However, it does enable creating the backfill of GitHub Releases to build an index.yaml with later.
This branch is not very appropriately named. I will follow up with a PR that adds the CI elements to maintain this going forwards. This PR is only for backfill and should not change state for #62.
Everything it does should be reversible (i.e. deleting releases in the GitHub UI), although to delete tags, you have to do a bit on the command line
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
(removed because this does not change chart data)