Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suport iPhone 6 #77

Closed
wants to merge 1 commit into from
Closed

Suport iPhone 6 #77

wants to merge 1 commit into from

Conversation

eduardokraus
Copy link

Adding image to support iPhone 6

Platforms affected

iPhone 6, iPhone 6s, iPhone 6s Plus and iPhone 6 Plus

What does this PR do?

Adds two new images for iPhone 6

What testing has been done on this change?

This in two app in production

Two missing images from CDVCapture.bundle?

https://drive.google.com/open?id=0B0IJT5Rizu5ORkZyOWNHdkwzdXc

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Adding image to support iPhone 6
@jcesarmobile
Copy link
Member

The code looks good, but the problem is those images don't exist.
Could you add them to the PR?

@eduardokraus
Copy link
Author

@jcesarmobile
Copy link
Member

@eduardokraus I saw the images on that link, but can you add them to the PR? if you don't add them to the CDVCapture.bundle they won't work

@eduardokraus
Copy link
Author

I do not have editing permission nor can I get a PUSH

@jcesarmobile
Copy link
Member

If you add a new commit to your local patch-1 branch and push it to your remote branch patch-1, the changes will be added to this PR

@timbru31
Copy link
Member

timbru31 commented May 6, 2019

PR #76 does the same and sadly the Google Drive link is not working anymore. I'm closing this PR. Thanks a lot for your effort!

@timbru31 timbru31 closed this May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants