Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): Implement property 'quality' in captureImage() (CB-11630) #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryanwilliams83
Copy link

Platforms affected

iOS

What does this PR do?

Allows developers to set JPEG compression quality

What testing has been done on this change?

captureImage()
'quality' omitted / 0 / 0.0 / 0.1 / 0.3 / 0.5 / 0.96 / 0.99 / 1 / 100

Checklist

  • ICLA has been signed and submitted to [email protected].
  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old but gold! LGTM 👍

@timbru31 timbru31 requested a review from janpio May 6, 2019 20:56
@janpio
Copy link
Member

janpio commented May 6, 2019

Is there anything comparable in one of our other plugins?
Is there an equivalent feature possible for Android?
What happens on Android when this param is supplied, which is not support there (yet)?
Any way to test this via automated tests?

@timbru31
Copy link
Member

timbru31 commented May 6, 2019 via email

@janpio
Copy link
Member

janpio commented May 6, 2019

Is there anything comparable in one of our other plugins?
What do you mean?

This is not the only plugin taking pictures. Does e.g. camera plugin have similar functionality? If so, does the API match?

@janpio janpio changed the title CB-11630: (iOS) Implement property 'quality' in captureImage() feat(ios): Implement property 'quality' in captureImage() (CB-11630) Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants