fix(android): close cursors to suppress log warnings#775
Closed
manstie wants to merge 1 commit intoapache:masterfrom
Closed
fix(android): close cursors to suppress log warnings#775manstie wants to merge 1 commit intoapache:masterfrom
manstie wants to merge 1 commit intoapache:masterfrom
Conversation
"W/System: A resource failed to call close" is logged whenever a Cursor object is left unclosed in this file. `queryImgDB` "May return null if the underlying content provider returns null, or if it crashes." so check for null.
Contributor
|
Obsolete since #907 removed the usage involving |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
android.content.ContentResolver.queryreturns:So we should check for
nullCursors after runningqueryImgDBDescription
Testing
I ran an app using this plugin in debug mode through Android Studio and confirmed the warnings no longer appear after these changes have been made.