Skip to content

fix(android): close cursors to suppress log warnings#775

Closed
manstie wants to merge 1 commit intoapache:masterfrom
manstie:patch-1
Closed

fix(android): close cursors to suppress log warnings#775
manstie wants to merge 1 commit intoapache:masterfrom
manstie:patch-1

Conversation

@manstie
Copy link
Copy Markdown

@manstie manstie commented Nov 9, 2021

Platforms affected

Android

Motivation and Context

  • "W/System: A resource failed to call close" is logged whenever a Cursor object is left unclosed in this file.
  • android.content.ContentResolver.query returns:
A Cursor object, which is positioned before the first entry. May return null if the underlying content provider returns null, or if it crashes.

So we should check for null Cursors after running queryImgDB

Description

  • Added null checks before running functions on Cursor objects.
  • Close all cursor objects after they have been created and used.

Testing

I ran an app using this plugin in debug mode through Android Studio and confirmed the warnings no longer appear after these changes have been made.

"W/System: A resource failed to call close" is logged whenever a Cursor object is left unclosed in this file. `queryImgDB`  "May return null if the underlying content provider returns null, or if it crashes." so check for null.
@erisu erisu changed the title (android) Close cursors to suppress log warnings fix(android): close cursors to suppress log warnings Mar 18, 2022
@breautek
Copy link
Copy Markdown
Contributor

Obsolete since #907 removed the usage involving Cursor.

@breautek breautek closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants