Skip to content

Commit

Permalink
refactor: formatted a todo block
Browse files Browse the repository at this point in the history
  • Loading branch information
erisu committed Jan 29, 2025
1 parent 421e120 commit c48bc45
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions framework/src/org/apache/cordova/PluginManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -371,12 +371,14 @@ public void onNewIntent(Intent intent) {
}

/**
* @todo should we move this somewhere public and accessible by all plugins?
* For now, it is placed where it is used and kept private so we can decide later and move without causing a breaking change.
* An ideal location might be in the "ConfigXmlParser" at the time it generates the "launchUrl".
* TODO: should we move this somewhere public and accessible by all plugins?
*
* @todo should we be restrictive on the "file://" return? e.g. "file:///android_asset/www/"
* Would be considered as a breaking change if we apply a more granular check.
* <p>For now, it is placed where it is used and kept private so we can decide later and move without causing a breaking change.
* An ideal location might be in the "ConfigXmlParser" at the time it generates the "launchUrl".</p>
*
* TODO: should we be restrictive on the "file://" return? e.g. "file:///android_asset/www/"
*
* <p>Would be considered as a breaking change if we apply a more granular check.</p>
*/
private String getLaunchUrlPrefix() {
if (!app.getPreferences().getBoolean("AndroidInsecureFileModeEnabled", false)) {
Expand Down

0 comments on commit c48bc45

Please sign in to comment.