Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXEC-121] Wait for async execution until process has started #144

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Marcono1234
Copy link
Contributor

This also has the side effect of ensuring that the process destroyer, if any, is registered.

Have marked this as draft for now because I am not sure if this a good solution. It causes the following behavior differences (which might be acceptable though):

  • Longer delay for async execution because calling thread now has to wait until process is started
  • Fail-fast behavior might be unexpected for caller; might expect that failure is reported through ExecuteStreamHandler

Maybe the race condition reported in EXEC-121 could also be solved differently by having another shutdown hook which verifies that all processes are started and their process destroyers (if any) have been registered. Though this logic might be quite complicated.

@Marcono1234 Marcono1234 changed the title [EXEC-121] Fail fast async execution for non-existing executable [EXEC-121] Wait for async execution until process has started Jan 6, 2024
This also has the side effect of ensuring that the process destroyer, if any,
is registered.
@Marcono1234 Marcono1234 force-pushed the EXEC-121-async-process-destroyer branch from 1537887 to 9859217 Compare January 6, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant