Fixes for Import VM Tasks listing #11841

nvazquez · 2025-10-15T02:34:36Z

Description

This PR fixes UI pagination and small issues on the Import VM Tasks listing

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

nvazquez · 2025-10-15T02:35:57Z

@blueorangutan package

blueorangutan · 2025-10-15T02:38:04Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-10-15T02:42:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.58%. Comparing base (349feeb) to head (5321550).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##            main   #11841      +/-   ##
=========================================
- Coverage   3.58%    3.58%   -0.01%     
=========================================
  Files        445      445              
  Lines      37494    37532      +38     
  Branches    6889     6901      +12     
=========================================
  Hits        1346     1346              
- Misses     35984    36022      +38     
  Partials     164      164

Flag	Coverage Δ
uitests	`3.58% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-10-15T04:14:33Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15458

nvazquez · 2025-10-15T16:07:48Z

@blueorangutan package

Pearl1594

code lgtm. Left a few small comments

Pearl1594 · 2025-10-15T16:10:37Z

api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ListImportVMTasksCmd.java

-
-    @Parameter(name = ApiConstants.SHOW_COMPLETED, type = CommandType.BOOLEAN, description = "Whether to list completed tasks.")
-    private boolean showCompleted = false;
+    @Parameter(name = ApiConstants.STATE, type = CommandType.STRING, description = "List tasks by status, valid options are: Running, Completed, Failed")


should we add a since field?

Thanks @Pearl1594, the since parameter is added on the API class entirely and it will use that one as all the parameters have been added on the same version (4.22)

Pearl1594 · 2025-10-15T16:11:12Z

api/src/main/java/org/apache/cloudstack/api/response/ImportVMTaskResponse.java

    private String displayName;

+    @SerializedName(ApiConstants.STATE)
+    @Param(description = "the state of the importing VM task")


nvazquez · 2025-10-15T16:32:26Z

@blueorangutan package

blueorangutan · 2025-10-15T16:34:04Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-15T17:49:18Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15468

nvazquez · 2025-10-15T18:02:59Z

@blueorangutan test

blueorangutan · 2025-10-15T18:04:04Z

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

nvazquez · 2025-10-15T21:24:11Z

@blueorangutan package

blueorangutan · 2025-10-15T21:26:04Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-15T23:12:49Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15469

NuxRo

LGTM based on actual testing, UI improvements are nice, good job

shwstppr

One comment otherwise code looks good

shwstppr · 2025-10-16T05:13:32Z

api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ListImportVMTasksCmd.java

-
-    @Parameter(name = ApiConstants.SHOW_COMPLETED, type = CommandType.BOOLEAN, description = "Whether to list completed tasks.")
-    private boolean showCompleted = false;
+    @Parameter(name = ApiConstants.TASKS_FILTER, type = CommandType.STRING, description = "Filter tasks by status, valid options are: All, Running, Completed, Failed")


Would it be better to name it state or status?

Thanks @shwstppr, fixed this description to match with state

blueorangutan · 2025-10-16T09:25:21Z

[SF] Trillian test result (tid-14690)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52220 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11841-t14690-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

harikrishna-patnala

LGTM

* Fix import VM tasks pagination * Fix UI for pagination and proper listing * Fixes and improvements * Polish UI * Restore config.json * Fix state on parameter description

nvazquez added 2 commits October 14, 2025 19:46

Fix import VM tasks pagination

466e888

Fix UI for pagination and proper listing

8acd7f5

nvazquez added this to the 4.22.0 milestone Oct 15, 2025

nvazquez added type:bug component:UI component:import labels Oct 15, 2025

boring-cyborg bot added the component:api label Oct 15, 2025

Fixes and improvements

83e6888

nvazquez marked this pull request as ready for review October 15, 2025 16:07

nvazquez requested review from NuxRo, Pearl1594, harikrishna-patnala, shwstppr, vishesh92 and vladimirpetrov October 15, 2025 16:09

Pearl1594 approved these changes Oct 15, 2025

View reviewed changes

nvazquez added 2 commits October 15, 2025 18:20

Polish UI

525cc58

Restore config.json

715b826

NuxRo approved these changes Oct 16, 2025

View reviewed changes

shwstppr reviewed Oct 16, 2025

View reviewed changes

Fix state on parameter description

5321550

harikrishna-patnala approved these changes Oct 16, 2025

View reviewed changes

harikrishna-patnala merged commit e7a55a7 into apache:main Oct 16, 2025
9 of 28 checks passed

harikrishna-patnala deleted the 422-vmwaretokvm-cleanup-fixes branch October 16, 2025 13:26

Fixes for Import VM Tasks listing #11841

Fixes for Import VM Tasks listing #11841

Conversation

nvazquez commented Oct 15, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

nvazquez commented Oct 15, 2025

Uh oh!

blueorangutan commented Oct 15, 2025

Uh oh!

codecov bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Oct 15, 2025

Uh oh!

nvazquez commented Oct 15, 2025

Uh oh!

Pearl1594 left a comment

Choose a reason for hiding this comment

Uh oh!

Pearl1594 Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

nvazquez Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Pearl1594 Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Oct 15, 2025

Uh oh!

blueorangutan commented Oct 15, 2025

Uh oh!

blueorangutan commented Oct 15, 2025

Uh oh!

nvazquez commented Oct 15, 2025

Uh oh!

blueorangutan commented Oct 15, 2025

Uh oh!

nvazquez commented Oct 15, 2025

Uh oh!

blueorangutan commented Oct 15, 2025

Uh oh!

blueorangutan commented Oct 15, 2025

Uh oh!

NuxRo left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

nvazquez Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Oct 16, 2025

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Oct 15, 2025 •

edited

Loading