Improve socketChannel closing in NioConnection

[harikrishna-patnala]

Description

This PR improves the closing of the socket whenever the connection is closed in Nioconnection.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

code lgtm

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[rohityadavcloud]

Looks like this could be useful for 4.20 branch, can you change base to 4.20 @harikrishna-patnala ?

[codecov]

Codecov Report

Attention: Patch coverage is 10.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 16.53%. Comparing base (7bab40d) to head (81a54e3).
Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
...c/main/java/com/cloud/utils/nio/NioConnection.java	3.57%	27 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10895      +/-   ##
============================================
+ Coverage     16.39%   16.53%   +0.13%     
- Complexity    13626    13802     +176     
============================================
  Files          5708     5717       +9     
  Lines        504062   506313    +2251     
  Branches      61103    61441     +338     
============================================
+ Hits          82649    83694    +1045     
- Misses       412213   413243    +1030     
- Partials       9200     9376     +176     

Flag	Coverage Δ
uitests	3.97% <ø> (-0.03%)	⬇️
unittests	17.40% <10.00%> (+0.14%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[harikrishna-patnala]

Looks like this could be useful for 4.20 branch, can you change base to 4.20 @harikrishna-patnala ?

@rohityadavcloud the related changes are not there in 4.20, so this is targeted for main

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13460

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13360)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55560 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10895-t13360-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File