-
Notifications
You must be signed in to change notification settings - Fork 71
Use ergochat/readline #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ Build complete for PR #199. 🔗 Download the cmk binaries (expires on November 16, 2025) |
97977d5 to
22a5e90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates from the unmaintained github.com/chzyer/readline library to github.com/ergochat/readline and removes the vendor directory dependency management approach in favor of standard Go module handling.
- Replaces
chzyer/readlinewithergochat/readlinev0.1.3 - Removes all vendor-related build flags and commands across build configuration files
- Updates dependency versions (golang.org/x/sys and adds golang.org/x/text)
Reviewed Changes
Copilot reviewed 4 out of 512 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates readline dependency and bumps indirect dependencies |
| cli/prompt.go | Changes readline import to use ergochat package |
| Makefile | Removes -mod=vendor flags from all build commands and vendor dependencies from targets |
| snap/snapcraft.yaml | Removes go mod vendor command from snap build process |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@vishesh92 there were some customisations in the existing lib, not sure they need to be included with the change. |
Let me compare with the upstream readline library. Do you know if there is any other library which was changed? We should ideally move away from vendor based setup. |
d86f1f8 to
eceb07f
Compare
|
@shwstppr I have migrated the changes in readline package to the new one and keeping the vendors directory. |
shwstppr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vishesh92 tested build for this PR. For some reasons prompt goes missing when autocompletion is invoked
cmk-prompt-goes-missing.webm
Fixes #137 and removes vendor directory.