Skip to content

Conversation

@vishesh92
Copy link
Member

Fixes #137 and removes vendor directory.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

✅ Build complete for PR #199.

🔗 Download the cmk binaries (expires on November 16, 2025)

@vishesh92 vishesh92 force-pushed the update-readline-and-remove-vendors branch from 97977d5 to 22a5e90 Compare November 3, 2025 11:43
@vishesh92 vishesh92 requested a review from Copilot November 3, 2025 11:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates from the unmaintained github.com/chzyer/readline library to github.com/ergochat/readline and removes the vendor directory dependency management approach in favor of standard Go module handling.

  • Replaces chzyer/readline with ergochat/readline v0.1.3
  • Removes all vendor-related build flags and commands across build configuration files
  • Updates dependency versions (golang.org/x/sys and adds golang.org/x/text)

Reviewed Changes

Copilot reviewed 4 out of 512 changed files in this pull request and generated no comments.

File Description
go.mod Updates readline dependency and bumps indirect dependencies
cli/prompt.go Changes readline import to use ergochat package
Makefile Removes -mod=vendor flags from all build commands and vendor dependencies from targets
snap/snapcraft.yaml Removes go mod vendor command from snap build process

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shwstppr
Copy link
Contributor

shwstppr commented Nov 4, 2025

@vishesh92 there were some customisations in the existing lib, not sure they need to be included with the change.
One I did was to allow autocompletion by name of the resources

@vishesh92
Copy link
Member Author

@vishesh92 there were some customisations in the existing lib, not sure they need to be included with the change.
One I did was to allow autocompletion by name of the resources

Let me compare with the upstream readline library. Do you know if there is any other library which was changed? We should ideally move away from vendor based setup.

@vishesh92 vishesh92 force-pushed the update-readline-and-remove-vendors branch from d86f1f8 to eceb07f Compare November 5, 2025 09:07
@vishesh92
Copy link
Member Author

@shwstppr I have migrated the changes in readline package to the new one and keeping the vendors directory.

@vishesh92 vishesh92 changed the title Use ergochat/readline and remove vendors directory Use ergochat/readline Nov 5, 2025
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishesh92 tested build for this PR. For some reasons prompt goes missing when autocompletion is invoked
cmk-prompt-goes-missing.webm

Screenshot from 2025-11-06 14-35-11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Readline issues when line goes beyond screen width

2 participants